Page MenuHomePhabricator

Don't warn about conflicts when reverting Phriction documents
ClosedPublic

Authored by epriestley on May 21 2014, 9:48 PM.

Details

Summary

Fixes T5144. This was incorrectly checking the content version, not the head version, so reverts would raise the "conflict" warning.

Also fix a couple of FontAwesome icons.

Test Plan
  • Edited a document.
  • Reverted a document.
  • Opened two edit tabs. Edited one, tried to edit #2, got a warning.
  • Opened two revert tabs. Reverted in one, tried to revert in #2, got a warning.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Don't warn about conflicts when reverting Phriction documents.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 21 2014, 10:58 PM
epriestley updated this revision to Diff 21965.

Closed by commit rP3c8d88deb454 (authored by @epriestley).