Page MenuHomePhabricator

Fix weird subscribe+comment rendering
ClosedPublic

Authored by epriestley on May 21 2014, 8:17 PM.
Tags
None
Referenced Files
F15383092: D9245.id21957.diff
Fri, Mar 14, 3:33 PM
Unknown Object (File)
Sun, Mar 2, 6:30 AM
Unknown Object (File)
Feb 15 2025, 5:56 AM
Unknown Object (File)
Jan 16 2025, 2:51 AM
Unknown Object (File)
Jan 9 2025, 3:41 PM
Unknown Object (File)
Jan 9 2025, 3:41 PM
Unknown Object (File)
Jan 9 2025, 3:41 PM
Unknown Object (File)
Jan 9 2025, 1:13 PM
Subscribers

Details

Summary

Fixes T5146. When we're rendering a transaction group that includes a comment, we hide the "x added a comment" text, since it's implicit and obvious and cleans the UI up a little.

However, the way this works is really complicated and messy and created the T5146 issue after I made self-subscriptions have a lower priority than comments do.

Clean this code up so it makes a little more sense and gets this case right.

Test Plan

Screen_Shot_2014-05-21_at_1.11.18_PM.png (100×1 px, 16 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix weird subscribe+comment rendering.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/view/phui/PHUITimelineEventView.php
424

This also fixes a bug where "PREVIEW" could render more than once for some transactions.

btrahan edited edge metadata.

nice cleanup!

This revision is now accepted and ready to land.May 21 2014, 8:27 PM
src/view/phui/PHUITimelineEventView.php
304–305

(Got rid of this locally, no longer used.)

454

(And this fixes a bug where we go to a whole lot of trouble above to get the earliest timestamp, and then just pick the first timestamp instead.)

epriestley updated this revision to Diff 21958.

Closed by commit rPa9d6a2f02dcb (authored by @epriestley).