Paths

Table of Contentst

Differential D9238

Allow dashboard panel policies to be edited
ClosedPublic
Actions

Authored by lpriestley on May 21 2014, 5:38 PM.

Tags

None

Referenced Files

	F13196161: D9238.diff
	Sun, May 12, 11:01 PM

	F13181781: D9238.diff
	Thu, May 9, 3:32 PM

	Unknown Object (File)
	Fri, May 3, 2:53 AM

	Unknown Object (File)
	Mon, Apr 29, 2:27 PM

	Unknown Object (File)
	Wed, Apr 24, 10:06 PM

	Unknown Object (File)
	Mon, Apr 15, 4:15 AM

	Unknown Object (File)
	Apr 11 2024, 7:41 AM

	Unknown Object (File)
	Apr 11 2024, 5:10 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4982: Allow dashboard Panel view and edit policies to be configured

Commits

Restricted Diffusion Commit
rP953f95054f60: Allow dashboard panel policies to be edited

Summary

Fixes T4982, expose dashboard panel policy editing to UI

Test Plan

Create panel, verify that user can edit who can see and who can edit panel

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 21941.May 21 2014, 5:38 PM

lpriestley retitled this revision from to Allow dashboard panel policies to be edited.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4982: Allow dashboard Panel view and edit policies to be configured.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 21 2014, 5:38 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B629: Diff 21941.May 21 2014, 5:39 PM

epriestley requested changes to this revision.May 21 2014, 5:41 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
112–113	I think these should be `$panel`, not `$credential`. (I'm surprised lint doesn't catch this, I'll see if I can fix the rule.)
src/applications/dashboard/storage/PhabricatorDashboardPanelTransaction.php
90–95 ↗	(On Diff #21941)	Hmm, I don't expect this part to be necessary. Can you walk me through what this fixes?

This revision now requires changes to proceed.May 21 2014, 5:41 PM

lpriestley added inline comments.May 21 2014, 5:46 PM

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php
112–113	copy pasta

Removing unnecessary code and fixing copy/paste surplus

Harbormaster completed remote builds in B630: Diff 21942.May 21 2014, 5:48 PM

epriestley accepted this revision.May 21 2014, 5:48 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 21 2014, 5:48 PM

Closed by commit rP953f95054f60 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

controller/

PhabricatorDashboardPanelEditController.php

38 lines

editor/

PhabricatorDashboardPanelTransactionEditor.php

2 lines

Diff 21943

src/applications/dashboard/controller/PhabricatorDashboardPanelEditController.php

Loading...

src/applications/dashboard/editor/PhabricatorDashboardPanelTransactionEditor.php

Loading...