Page MenuHomePhabricator

Allow workboards to be filtered with ApplicationSearch
ClosedPublic

Authored by epriestley on May 20 2014, 2:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 8:41 PM
Unknown Object (File)
Thu, Apr 4, 7:50 AM
Unknown Object (File)
Mon, Apr 1, 1:26 AM
Unknown Object (File)
Sat, Mar 30, 9:39 PM
Unknown Object (File)
Thu, Mar 21, 4:03 AM
Unknown Object (File)
Feb 26 2024, 10:19 AM
Unknown Object (File)
Feb 21 2024, 12:17 PM
Unknown Object (File)
Feb 10 2024, 11:23 PM

Details

Summary

Ref T4673.

IMPORTANT: I had to break one thing (see TODO) to get this working. Not sure how you want to deal with that. I might be able to put the element inside the workboard, or I could write some JS. But I figured I'd get feedback first.

General areas for improvement:

  • It would be nice to give you some feedback that you have a filter applied.
  • It would be nice to let you save and quickly select common filters.
  • These would probably both be covered by a dropdown menu instead of a button, but that's more JS than I want to sign up for right now.
  • Managing custom filters is also a significant amount of extra UI to build.
  • Also, maybe these filters should be sticky per-board? Or across all boards? Or have a "make this my default view"? I tend to dislike implicit stickiness.
Test Plan

Before:

Screen_Shot_2014-05-20_at_7.47.05_AM.png (950×1 px, 144 KB)

Apply Filter:

Screen_Shot_2014-05-20_at_7.47.11_AM.png (950×1 px, 146 KB)

Filtered:

Screen_Shot_2014-05-20_at_7.47.15_AM.png (950×1 px, 150 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow workboards to be filtered with ApplicationSearch.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.

Let me make some coffee and see if I can summon the courage to turn this into a dropdown (unless you have other ideas). I think it's like too hideous/unwieldy to ship as-is. I think it's good that this mode exists, but it should be in like "Filter > Advanced Filter...", not "Filter".

Also, I'm going to fix that "absolute" thing by just popping this up as a dialog. So "Filter" would become a dropdown menu:

[Filter Tasks v]
(Open Tasks)
(All Tasks)
([saved stuff goes here eventually])
(Custom Filter...)

The last one pops a dialog with the full filter UI.

I can just put a couple of prebuilt filters in there for now and skip all the saved filter stuff, which should make this reasonably manageable.

It's interesting to me how these questions change if they lived in a Workboards application. Things like global filters, etc, make more sense there.

My sense is people would potentially want different filters for different projects. That is, a Sprint Project would maybe show closed tasks, but not a more standard Security Project or Design Team project. Perhaps having a global default in and a local override (not implicit sticky).

At least, it seems easy to start with a Global Filter across all boards, then see if there are reasons for local views. Local views could also just be covered by Dashboards.

Lots of possibilities for improvement but these are a lot of work too!

IMO it's already great to be able to filter tasks in the boards. A couple uses I can think of are to only show tasks assigned to a given user or to uncheck the "open" checkbox in the filter (since I assume the default filter will be "show all open tasks") to make closed tasks visible again.

It might be worth to release this implementation as-is and see if there's even a need to customize the default filter and / or save filters across boards.

epriestley edited edge metadata.
  • Fix all major UI horribleness.

The work on dropdowns a couple weeks ago made this relatively painless. Here's the new flow:

Default view: shows current filter.

Screen_Shot_2014-05-20_at_9.27.36_AM.png (1×1 px, 151 KB)

Open dropdown:

Screen_Shot_2014-05-20_at_9.27.41_AM.png (1×1 px, 163 KB)

Pick a different default filter:

Screen_Shot_2014-05-20_at_9.27.43_AM.png (1×1 px, 156 KB)

Advanced filter:

Screen_Shot_2014-05-20_at_9.27.48_AM.png (1×1 px, 169 KB)

Advanced filter applied, shows as "Custom Filter":

Screen_Shot_2014-05-20_at_9.27.55_AM.png (1×1 px, 124 KB)

@chad, the one issue with this is that setDropdown() (and the "open" state of the button) look glitchy when the item is rendered in this context. Those should be pure CSS fixes, I left you a TODO.

  • We need to retain the order specification for now.
This revision is now accepted and ready to land.May 20 2014, 5:31 PM
epriestley edited edge metadata.
  • Add "assigned" as a prebuilt filter.
  • (Viewed while logged in, and while logged out.)
epriestley updated this revision to Diff 21898.

Closed by commit rPf0147fd8add1 (authored by @epriestley).