Paths

Table of Contentst

Make PeopleQuery throw, not select everything, when handed empty array
ClosedPublic
Actions

Authored by epriestley on May 20 2014, 1:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 29, 3:20 PM

	Unknown Object (File)
	Sat, Apr 27, 3:11 PM

	Unknown Object (File)
	Sat, Apr 27, 3:11 PM

	Unknown Object (File)
	Fri, Apr 26, 9:41 AM

	Unknown Object (File)
	Wed, Apr 24, 10:23 PM

	Unknown Object (File)
	Wed, Apr 24, 7:32 PM

	Unknown Object (File)
	Apr 1 2024, 7:40 PM

	Unknown Object (File)
	Mar 19 2024, 5:50 PM

View All 91 Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPbed9ce2d1897: Make PeopleQuery throw, not select everything, when handed empty array

Summary

Make ->withPHIDs(array()) throw on this query instead of selecting everything.

Test Plan

Poked around.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21876.May 20 2014, 1:59 PM

epriestley retitled this revision from to Make PeopleQuery throw, not select everything, when handed empty array.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 20 2014, 1:59 PM

Harbormaster completed remote builds in B590: Diff 21876.May 20 2014, 2:00 PM

chad accepted this revision.May 20 2014, 2:21 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.May 20 2014, 2:21 PM

Closed by commit rPbed9ce2d1897 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

query/

PhabricatorPeopleQuery.php

10 lines

Diff 21880

View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Make PeopleQuery throw, not select everything, when handed empty arrayClosedPublicActions