Page MenuHomePhabricator

Make PeopleQuery throw, not select everything, when handed empty array
ClosedPublic

Authored by epriestley on May 20 2014, 1:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 14 2025, 12:22 AM
Unknown Object (File)
May 20 2025, 2:24 AM
Unknown Object (File)
May 9 2025, 7:20 PM
Unknown Object (File)
May 8 2025, 9:24 AM
Unknown Object (File)
Apr 26 2025, 1:38 AM
Unknown Object (File)
Apr 22 2025, 9:53 PM
Unknown Object (File)
Mar 17 2025, 2:45 PM
Unknown Object (File)
Mar 15 2025, 11:09 PM
Subscribers

Details

Summary

Make ->withPHIDs(array()) throw on this query instead of selecting everything.

Test Plan

Poked around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make PeopleQuery throw, not select everything, when handed empty array.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.May 20 2014, 2:21 PM
epriestley updated this revision to Diff 21880.

Closed by commit rPbed9ce2d1897 (authored by @epriestley).