Differential D9206

Dashboards - add ability to install dashboard as home
ClosedPublic
Actions

Authored by btrahan on May 19 2014, 10:47 PM.

Tags

None

Referenced Files

	F18762443: D9206.id21874.diff
	Mon, Oct 6, 7:02 PM

	F18734886: D9206.id.diff
	Tue, Sep 30, 11:05 PM

	F18695580: D9206.id21868.diff
	Sat, Sep 27, 6:05 AM

	F18628538: D9206.id.diff
	Tue, Sep 16, 6:32 AM

	F18596080: D9206.id21868.diff
	Fri, Sep 12, 11:39 PM

	F18594763: D9206.diff
	Fri, Sep 12, 7:17 PM

	F18593081: D9206.id21868.diff
	Fri, Sep 12, 1:51 PM

	F18586293: D9206.id21874.diff
	Thu, Sep 11, 6:10 PM

Subscribers

Tokens

"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5076: Add an "Install Dashboard" workflow

Commits

Restricted Diffusion Commit
rP5f33aa5b4f6a: Dashboards - add ability to install dashboard as home

Summary

See title. Adds PhabricatorDashboardInstall data object which scopes installs to objectPHID + applicationClass. This is because we already have a collision for user home pages and user profiles. Assume only one dashboard per objectPHID + applicationClass though at the database level.

Fixes T5076.

Test Plan

From dashboard view, installed a dashboard - success! Went back to dashboard view and uninstalled it!

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 21868.May 19 2014, 10:47 PM

btrahan added a task: T5076: Add an "Install Dashboard" workflow.

btrahan retitled this revision from to Dashboards - add ability to install dashboard as home.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 19 2014, 10:48 PM

Harbormaster completed remote builds in B583: Diff 21868.May 19 2014, 10:49 PM

start home page

Screen_Shot_2014-05-19_at_3.46.02_PM.png (1×2 px, 606 KB)

I like me this dashboard - install flow 1

Screen_Shot_2014-05-19_at_3.45.40_PM.png (1×2 px, 581 KB)

install flow 2

Screen_Shot_2014-05-19_at_3.45.45_PM.png (1×2 px, 556 KB)

installed !

Screen_Shot_2014-05-19_at_3.45.51_PM.png (1×2 px, 692 KB)

uninstall flow 1

Screen_Shot_2014-05-19_at_3.45.55_PM.png (1×2 px, 582 KB)

uninstall flow 2

Screen_Shot_2014-05-19_at_3.45.58_PM.png (1×2 px, 550 KB)

uninstalled - back to the start

Screen_Shot_2014-05-19_at_3.46.02_PM.png (1×2 px, 606 KB)

Uninstall?!? What is this, the year 3,000?!

This revision is now accepted and ready to land.May 19 2014, 10:59 PM

epriestley awarded a token.May 19 2014, 10:59 PM

...even support install dashboard A then install dashboard B...!

tested above and it now works

Closed by commit rP5f33aa5b4f6a (authored by @btrahan).

Harbormaster completed remote builds in B588: Diff 21873.May 19 2014, 11:09 PM

itsawesome

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140519.dashboardinstall.sql

10 lines

src/

__phutil_library_map__.php

6 lines

applications/

dashboard/

application/

PhabricatorApplicationDashboard.php

2 lines

controller/

PhabricatorDashboardInstallController.php

139 lines

PhabricatorDashboardUninstallController.php

136 lines

PhabricatorDashboardViewController.php

20 lines

storage/

PhabricatorDashboardInstall.php

38 lines

home/

controller/

PhabricatorHomeMainController.php

44 lines

Diff 21874

resources/sql/autopatches/20140519.dashboardinstall.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/dashboard/application/PhabricatorApplicationDashboard.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardInstallController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardUninstallController.php

Loading...

src/applications/dashboard/controller/PhabricatorDashboardViewController.php

Loading...

src/applications/dashboard/storage/PhabricatorDashboardInstall.php

Loading...

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...