Differential D9186

Don't disable the "Show Public Key" action for locked credentials
ClosedPublic
Actions

Authored by epriestley on May 18 2014, 10:03 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5104: Permanently locked passphrase credential has disabled but functional "Show Public key" button

Commits

Restricted Diffusion Commit
rPaf0edf883d89: Don't disable the "Show Public Key" action for locked credentials

Summary

Fixes T5104. It's still OK to reveal public keys of locked credentials -- the controller has the right logic, this UI just isn't in sync.

Test Plan

Viewed passphrase; saw enabled menu item on locked credential.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21817.May 18 2014, 10:03 PM

epriestley retitled this revision from to Don't disable the "Show Public Key" action for locked credentials.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5104: Permanently locked passphrase credential has disabled but functional "Show Public key" button.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2014, 10:03 PM

Harbormaster completed remote builds in B557: Diff 21817.May 18 2014, 10:04 PM

btrahan accepted this revision.May 19 2014, 6:52 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 19 2014, 6:52 PM

Closed by commit rPaf0edf883d89 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

controller/

PassphraseCredentialViewController.php

3 lines

Diff 21858

View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Don't disable the "Show Public Key" action for locked credentialsClosedPublicActions