Page MenuHomePhabricator

Allow projects to be "watched", sort of a super-subscribe
ClosedPublic

Authored by epriestley on May 18 2014, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:35 PM
Unknown Object (File)
Thu, Dec 12, 10:39 PM
Unknown Object (File)
Sun, Dec 8, 9:11 AM
Unknown Object (File)
Mon, Dec 2, 3:39 AM
Unknown Object (File)
Thu, Nov 28, 10:37 PM
Unknown Object (File)
Thu, Nov 28, 1:10 PM
Unknown Object (File)
Thu, Nov 28, 1:10 PM
Unknown Object (File)
Thu, Nov 28, 1:10 PM
Subscribers

Details

Summary

Ref T4967. Adds a "Watch" relationship to projects, which is stronger than member/subscribed.

Specifically, when a task is tagged with a project, we'll include all project watchers in the email/notifications. Normally we don't include projects unless they're explicitly CC'd, or have some other active role in the object (like being a reviewer or auditor).

This allows you to closely follow a project without needing to write a Herald rule for every project you care about.

Test Plan
  • Watched/unwatched a project.
  • Tested the watch/subscribe/member relationships:
    • Watching implies subscribe.
    • Joining implies subscribe.
    • Leaving implies unsubscribe + unwatch.
    • You can't unsubscribe until you unwatch (slightly better would be unsubscribe implies unwatch, but this is a bit tricky).
  • Watched a project, then recevied email about a tagged task without otherwise being involved.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Allow projects to be "watched", sort of a super-subscribe.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Before using members of the watch list, verify they can see the object.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2014, 6:59 PM
epriestley updated this revision to Diff 21859.

Closed by commit rP3a3155426898 (authored by @epriestley).