Page MenuHomePhabricator

Give audits a clickable commit title, even if they are importing or messageless
ClosedPublic

Authored by epriestley on May 17 2014, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 12:01 PM
Unknown Object (File)
Sat, Mar 16, 1:58 AM
Unknown Object (File)
Sat, Mar 9, 10:17 PM
Unknown Object (File)
Sat, Mar 9, 10:17 PM
Unknown Object (File)
Feb 7 2024, 8:57 PM
Unknown Object (File)
Jan 29 2024, 6:48 AM
Unknown Object (File)
Jan 29 2024, 5:22 AM
Unknown Object (File)
Dec 25 2023, 5:37 AM
Subscribers

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP28c198d9026e: Give audits a clickable commit title, even if they are importing or messageless
Summary

Fixes T3854. Subversion allows commits with no message, and in other cases we might not have imported the message yet. In these cases, we may not render any text inside the link.

When we hit these cases, render appropriate replacement text.

Test Plan

Screen_Shot_2014-05-17_at_3.03.41_PM.png (67×587 px, 11 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Give audits a clickable commit title, even if they are importing or messageless.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: Restricted Maniphest Task.
chad edited edge metadata.
This revision is now accepted and ready to land.May 17 2014, 10:20 PM
epriestley updated this revision to Diff 21781.

Closed by commit rP28c198d9026e (authored by @epriestley).