Page MenuHomePhabricator

Fix an incorrect filtering of groupless results from Maniphest "Group By" query
ClosedPublic

Authored by epriestley on May 16 2014, 3:42 PM.
Tags
None
Referenced Files
F15548615: D9152.diff
Sun, Apr 27, 1:02 AM
F15532940: D9152.id.diff
Wed, Apr 23, 5:42 PM
F15532044: D9152.id21738.diff
Wed, Apr 23, 2:17 PM
F15529083: D9152.diff
Tue, Apr 22, 4:34 PM
F15515697: D9152.id21738.diff
Fri, Apr 18, 12:51 PM
F15487785: D9152.diff
Thu, Apr 10, 4:58 PM
F15453740: D9152.id21738.diff
Mar 29 2025, 1:59 PM
F15453739: D9152.id21736.diff
Mar 29 2025, 1:59 PM
Subscribers

Details

Summary

Fixes T5081. This block enforces policies and prevents you from seeing groups associated with projects you can't see. However, it incorrectly removes tasks which end up with no group key. This can happen in two cases:

  • The task isn't in a project.
  • The task is in a project, but the query includes an "In All Projects: <that project>" constraint. In that case, we don't show the group becuase it would always contain every task.
Test Plan

Replicated the setup in T5081, saw an "Ungrouped" group with "Task A":

Screen_Shot_2014-05-16_at_8.42.22_AM.png (320×1 px, 29 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix an incorrect filtering of groupless results from Maniphest "Group By" query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 16 2014, 3:43 PM
epriestley updated this revision to Diff 21738.

Closed by commit rP3e9a988cd71f (authored by @epriestley).