Differential D9152

Fix an incorrect filtering of groupless results from Maniphest "Group By" query
ClosedPublic
Actions

Authored by epriestley on May 16 2014, 3:42 PM.

Tags

None

Referenced Files

	F15453740: D9152.id21738.diff
	Sat, Mar 29, 1:59 PM

	F15453739: D9152.id21736.diff
	Sat, Mar 29, 1:59 PM

	F15436522: D9152.id.diff
	Tue, Mar 25, 2:51 PM

	F15426360: D9152.id.diff
	Sun, Mar 23, 8:13 AM

	F15389951: D9152.id21736.diff
	Sat, Mar 15, 5:47 AM

	F15389845: D9152.id.diff
	Sat, Mar 15, 5:41 AM

	F15368384: D9152.id21736.diff
	Wed, Mar 12, 1:43 AM

	F15308964: D9152.id21736.diff
	Thu, Mar 6, 6:47 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T5081: Grouping Maniphest query results by group doesn't have a "orphan" group or equivalent

Commits

Restricted Diffusion Commit
rP3e9a988cd71f: Fix an incorrect filtering of groupless results from Maniphest "Group By" query

Summary

Fixes T5081. This block enforces policies and prevents you from seeing groups associated with projects you can't see. However, it incorrectly removes tasks which end up with no group key. This can happen in two cases:

The task isn't in a project.
The task is in a project, but the query includes an "In All Projects: <that project>" constraint. In that case, we don't show the group becuase it would always contain every task.

Test Plan

Replicated the setup in T5081, saw an "Ungrouped" group with "Task A":

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21736.May 16 2014, 3:42 PM

epriestley retitled this revision from to Fix an incorrect filtering of groupless results from Maniphest "Group By" query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5081: Grouping Maniphest query results by group doesn't have a "orphan" group or equivalent.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 16 2014, 3:42 PM

btrahan accepted this revision.May 16 2014, 3:43 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 16 2014, 3:43 PM

Harbormaster completed remote builds in B507: Diff 21736.May 16 2014, 3:43 PM

Closed by commit rP3e9a988cd71f (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

6 lines

view/

ManiphestTaskResultListView.php

7 lines

Diff 21738

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...

src/applications/maniphest/view/ManiphestTaskResultListView.php

Loading...