Differential D9128

Initial transition to use history table everywhere
AbandonedPublic
Actions

Authored by hach-que on May 15 2014, 2:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 23, 9:50 AM

	Unknown Object (File)
	Mon, Dec 23, 9:50 AM

	Unknown Object (File)
	Mon, Dec 23, 9:49 AM

	Unknown Object (File)
	Tue, Dec 17, 12:02 AM

	Unknown Object (File)
	Fri, Dec 6, 11:20 PM

	Unknown Object (File)
	Fri, Dec 6, 1:00 PM

	Unknown Object (File)
	Wed, Dec 4, 7:23 PM

	Unknown Object (File)
	Mon, Dec 2, 8:53 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5001: Store Diffusion lint information against a commit hash instead of a branch

Summary

This updates everywhere to use the history table to pull in lint and coverage information. At the moment the history entry is still resolved via the branch identifier.

This is not yet complete (i.e. it is a draft)

Test Plan

N/A

Diff Detail

Repository

Branch

historical-1

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/diffusion/controller/DiffusionLintController.php:54	XHP5	Use of Undeclared Variable
Error	src/applications/diffusion/request/DiffusionRequest.php:365	PHL1	Unknown Symbol
Warning	resources/sql/autopatches/20140515.history.2.sql:1	TXT3	Line Too Long
Warning	resources/sql/autopatches/20140515.history.2.sql:3	TXT3	Line Too Long
Advice	src/applications/diffusion/DiffusionLintSaveRunner.php:130	XHP16	TODO Comment
Advice	src/applications/diffusion/request/DiffusionRequest.php:355	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 473
Build 473: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 21684.May 15 2014, 2:14 AM

hach-que retitled this revision from to Initial transition to use history table everywhere.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T5001: Store Diffusion lint information against a commit hash instead of a branch.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2014, 2:14 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B473: Diff 21684.May 15 2014, 2:16 AM

hach-que abandoned this revision.May 15 2014, 2:52 AM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20140515.history.1.sql

6 lines

20140515.history.2.sql

7 lines

src/

__phutil_library_map__.php

2 lines

applications/

diffusion/

DiffusionLintSaveRunner.php

14 lines

controller/

DiffusionBrowseFileController.php

10 lines

DiffusionLastModifiedController.php

6 lines

DiffusionLintController.php

38 lines

DiffusionLintDetailsController.php

14 lines

query/

DiffusionLintCountQuery.php

16 lines

request/

DiffusionRequest.php

30 lines

view/

DiffusionBrowseTableView.php

4 lines

repository/

storage/

PhabricatorRepositoryHistory.php

14 lines

Diff 21684

resources/sql/autopatches/20140515.history.1.sql

Loading...

resources/sql/autopatches/20140515.history.2.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/diffusion/DiffusionLintSaveRunner.php

Loading...

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...

src/applications/diffusion/controller/DiffusionLastModifiedController.php

Loading...

src/applications/diffusion/controller/DiffusionLintController.php

Loading...

src/applications/diffusion/controller/DiffusionLintDetailsController.php

Loading...

src/applications/diffusion/query/DiffusionLintCountQuery.php

Loading...

src/applications/diffusion/request/DiffusionRequest.php

Loading...

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryHistory.php

Loading...