Page MenuHomePhabricator

Read 'phabricator.uri' and 'default' out of more config sources
ClosedPublic

Authored by epriestley on May 13 2014, 6:31 PM.

Details

Summary

We have old/inconsistent code for reading these. Instead, read from sources in a modern way.

Test Plan
  • Removed "default" and "phabricator.uri" from user/local/project config.
  • Set "default" in "/etc/arcconfig".
  • Ran arc tasks and got a "connect to Phabricator" message.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Read 'phabricator.uri' and 'default' out of more config sources.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

Specifically, "default" and "phabricator.uri" currently have no effect in system configuration.

davedash added a reviewer: davedash.
davedash added a subscriber: davedash.

Looks good to me.

This revision is now accepted and ready to land.May 13 2014, 6:36 PM
epriestley updated this revision to Diff 21622.

Closed by commit rARC85b6c581e11b (authored by @epriestley).