Page MenuHomePhabricator
Differential D9094

Throw a more tailored exception after failing to resolve a ref
ClosedPublic
Actions

Authored by epriestley on May 13 2014, 12:37 PM.
Tags
None
Referenced Files
F14388305: D9094.id21633.diff
Sat, Dec 21, 4:04 PM
Unknown Object (File)
Tue, Dec 17, 10:53 PM
Unknown Object (File)
Thu, Dec 12, 11:15 PM
Unknown Object (File)
Thu, Dec 12, 4:06 AM
Unknown Object (File)
Tue, Dec 10, 7:28 PM
Unknown Object (File)
Thu, Dec 5, 3:51 PM
Unknown Object (File)
Tue, Dec 3, 11:57 AM
Unknown Object (File)
Thu, Nov 28, 9:04 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2683: Improve the performance of Diffusion browse views
Commits
Restricted Diffusion Commit
rPb80b851600cb: Throw a more tailored exception after failing to resolve a ref
Summary

Ref T2683. Throw a more tailored exception to allow callers to distinguish between bad refs (which are expected, if users try to visit garbage branches) and other types of errors.

Test Plan

Tried to view branch "alksndfklansdf". Viewed branch "master".

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21604.May 13 2014, 12:37 PM
epriestley retitled this revision from to Throw a more tailored exception after failing to resolve a ref.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2683: Improve the performance of Diffusion browse views.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 13 2014, 12:37 PM
Harbormaster completed remote builds in B426: Diff 21604.May 13 2014, 12:39 PM
btrahan accepted this revision.May 13 2014, 4:39 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/diffusion/exception/DiffusionRefNotFoundException.php
8

i'd probably make this a member variable to avoid messing with the constructor signature. pretty whatevs.

This revision is now accepted and ready to land.May 13 2014, 4:39 PM
epriestley updated this revision to Diff 21620.May 13 2014, 4:43 PM
epriestley edited edge metadata.
  • Move the ref to a property instead.
Harbormaster completed remote builds in B438: Diff 21620.May 13 2014, 4:44 PM
epriestley closed this revision.May 13 2014, 8:52 PM
epriestley updated this revision to Diff 21633.

Closed by commit rPb80b851600cb (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
diffusion/
exception/
16 lines
request/
16 lines

Diff 21633

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/exception/DiffusionRefNotFoundException.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility