Allow the InRequest key-value cache to have a simple key limit
ClosedPublic
Actions

Authored by epriestley on May 12 2014, 7:22 PM.

Details

Reviewers

Commits

rPHUf253b0245454: Allow the InRequest key-value cache to have a simple key limit

Summary

Performance of the new graph cache is okay, but pulling data from APC is more expensive than I expected. I'm going to try to tune that by doing some in-request caching, since all requests normally examine the same bucket at first.

Test Plan

Added and executed unit tests.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21576.May 12 2014, 7:22 PM

epriestley retitled this revision from to Allow the InRequest key-value cache to have a simple key limit.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2014, 7:22 PM

Harbormaster completed remote builds in B405: Diff 21576.May 12 2014, 7:23 PM

btrahan accepted this revision.May 12 2014, 7:31 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2014, 7:31 PM

Closed by commit rPHUf253b0245454 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

cache/

PhutilKeyValueCacheInRequest.php

39 lines

__tests__/

PhutilKeyValueCacheTestCase.php

31 lines

Diff 21578

View Options

src/cache/PhutilKeyValueCacheInRequest.php

View Options

src/cache/tests/PhutilKeyValueCacheTestCase.php

Allow the InRequest key-value cache to have a simple key limitClosedPublicActions