Paths

Table of Contentst

Differential D8986

Fix cursor on mock card hover in pholio
ClosedPublic
Actions

Authored by lpriestley on May 5 2014, 11:30 PM.

Tags

None

Referenced Files

	F13255894: D8986.id21337.diff
	Sat, May 25, 9:07 AM

	F13253275: D8986.diff
	Sat, May 25, 2:33 AM

	F13241748: D8986.id21336.diff
	Wed, May 22, 11:12 PM

	F13241747: D8986.id21335.diff
	Wed, May 22, 11:12 PM

	F13241745: D8986.id21334.diff
	Wed, May 22, 11:12 PM

	F13241743: D8986.id.diff
	Wed, May 22, 11:12 PM

	F13241740: D8986.diff
	Wed, May 22, 11:12 PM

	F13236885: D8986.diff
	Tue, May 21, 11:22 AM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4888: Seemingly actionable area in Pholio "Mocks List" apparently isn't actually actionably

Commits

Restricted Diffusion Commit
rPb6185314512e: Fix cursor on mock card hover in pholio

Summary

Fixes T4888, make seemingly actionable area in Pholio "Mocks List" actually actionable

Test Plan

Open pholio, create a mock, return to list of all mocks, hover over mock, only image in mock should switch to pointer on hover.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

lpriestley updated this revision to Diff 21334.May 5 2014, 11:30 PM

lpriestley retitled this revision from to Fix cursor on mock card hover in pholio.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4888: Seemingly actionable area in Pholio "Mocks List" apparently isn't actually actionably.

Herald added reviewers: Blessed Reviewers, chad. · View Herald TranscriptMay 5 2014, 11:30 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B255: Diff 21334.May 5 2014, 11:32 PM

Can we just remove both these rules completely? The image link should get a pointer because it's inside a link, and the default cursor isn't overriding anything that I can see.

Removing some cursor rules

Harbormaster completed remote builds in B256: Diff 21335.May 6 2014, 12:05 AM

removing comment

epriestley accepted this revision.May 6 2014, 12:06 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 6 2014, 12:06 AM

Closed by commit rPb6185314512e (authored by @lpriestley, committed by @epriestley).

Harbormaster completed remote builds in B257: Diff 21336.May 6 2014, 12:06 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

webroot/

rsrc/

css/

phui/

phui-pinboard-view.css

1 line

Diff 21337

resources/celerity/map.php

Loading...

webroot/rsrc/css/phui/phui-pinboard-view.css

Loading...