Check view policy, not join policy, when raising an error for Phame custom domains
ClosedPublic
Actions

Authored by epriestley on May 5 2014, 3:18 PM.

Tags

None

Referenced Files

	F17948225: D8980.id21305.diff
	Thu, Jul 31, 8:23 PM

	F17877655: D8980.id.diff
	Mon, Jul 28, 7:46 PM

	F17851864: D8980.diff
	Sun, Jul 27, 11:51 AM

	Unknown Object (File)
	Jun 28 2025, 9:03 PM

	Unknown Object (File)
	Jun 28 2025, 3:00 PM

	Unknown Object (File)
	Jun 20 2025, 8:35 AM

	Unknown Object (File)
	Jun 19 2025, 1:08 PM

	Unknown Object (File)
	Jun 18 2025, 6:47 PM

View All Files

Subscribers

epriestley

legien

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPac9c82fcdf03: Check view policy, not join policy, when raising an error for Phame custom…

Summary

A user in IRC hit this; this looks like a typo.

Test Plan

Created a new blog with a public view policy, a non-public join policy, and a custom domain.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21305.May 5 2014, 3:18 PM

epriestley retitled this revision from to Check view policy, not join policy, when raising an error for Phame custom domains.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 5 2014, 3:18 PM

legien added a subscriber: legien.May 5 2014, 3:19 PM

Harbormaster completed remote builds in B247: Diff 21305.May 5 2014, 3:20 PM

btrahan accepted this revision.May 5 2014, 4:32 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 5 2014, 4:32 PM

Closed by commit rPac9c82fcdf03 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

blog/

PhameBlogEditController.php

2 lines

Diff 21312

View Options

src/applications/phame/controller/blog/PhameBlogEditController.php

Check view policy, not join policy, when raising an error for Phame custom domainsClosedPublicActions