Page MenuHomePhabricator

Use ActionList-based dropdowns in Conpherence
ClosedPublic

Authored by epriestley on May 4 2014, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 9:29 AM
Unknown Object (File)
Thu, Dec 12, 9:29 PM
Unknown Object (File)
Thu, Dec 12, 4:04 AM
Unknown Object (File)
Sun, Dec 8, 10:06 PM
Unknown Object (File)
Thu, Dec 5, 2:35 PM
Unknown Object (File)
Wed, Dec 4, 5:08 AM
Unknown Object (File)
Sat, Nov 30, 9:28 PM
Unknown Object (File)
Nov 26 2024, 4:52 PM
Subscribers

Details

Summary

See D8966, D8973. Replace PhabricatorDropdownMenu with PHUIXDropdownMenu.

These new menus look weird on mobile because all action lists pick up a bunch of weird styles on mobile and we're now reusing the CSS.

Test Plan

Screen_Shot_2014-05-04_at_1.28.08_PM.png (200×249 px, 12 KB)

Screen_Shot_2014-05-04_at_1.38.16_PM.png (744×396 px, 147 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use ActionList-based dropdowns in Conpherence.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
webroot/rsrc/css/layout/phabricator-action-list-view.css
9–12

All these .device rules probably need to be scoped to lists inside PHUIObjectBoxView or something like that?

btrahan edited edge metadata.

LGTM.

@chad - CSS question for you inline from @epriestley

webroot/rsrc/css/layout/phabricator-action-list-view.css
9–12

idk

This revision is now accepted and ready to land.May 5 2014, 4:48 PM
webroot/rsrc/css/layout/phabricator-action-list-view.css
9–12

To be less vague about this:

  • Unifying these styles means dropdown menus look odd on mobile. They're still usable, but they pick up padding and borders which are worse on the balance than the old look was. The next rule also has to overwrite a coarse display: none to get them to work.
  • I think the right fix here is to make these rules more granular, and target them to action lists inside PHUIObjectBoxView or similar. I'm not making this fix now because (a) I'm not certain it's right; (b) these diffs are already pretty large; (c) I was frustrated enough about spending like two days rewriting dropdown menus without digging into this too; and (d) as far as I know, everything is usable as is, it's just not very pretty.
  • My ideal resolution here is for @chad to refine these styles so they apply appropriately and send me a diff, which will probably mostly be adding .phui-box-view in the middle of some of these rules. Alternatively, I can take a stab at this, but it would be a big help if you could do it and you might want to tweak some of the other stuff I did anyway. The menus are a bit iffy right now but I don't think there's so bad that this represents a big bad-faith punt on my part or anything.

I'm happy to take a pass after landing

epriestley updated this revision to Diff 21319.

Closed by commit rP7584d10b49d8 (authored by @epriestley).