Differential D8969

Make the paste "Create" transaction take a file PHID instead of content
ClosedPublic
Actions

Authored by epriestley on May 3 2014, 11:35 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4814: Make paste edible

Commits

Restricted Diffusion Commit
rPc2f58496ad93: Make the paste "Create" transaction take a file PHID instead of content

Summary

Ref T4814. Although this approach made sense at one point, we have more file infrastructure now and T4814 will be easier if we just pass a PHID in.

Also swap Conduit over to use the Editor.

Test Plan

Created a paste.
Created a paste via Conduit.
Verified that files had correct permissions and appropriate object links in Files.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21274.May 3 2014, 11:35 PM

epriestley retitled this revision from to Make the paste "Create" transaction take a file PHID instead of content.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4814: Make paste edible.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 3 2014, 11:35 PM

Harbormaster completed remote builds in B224: Diff 21274.May 3 2014, 11:37 PM

Also you can create pastes via email apparently

Harbormaster completed remote builds in B225: Diff 21275.May 3 2014, 11:43 PM

btrahan accepted this revision.May 4 2014, 5:33 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 4 2014, 5:33 PM

Closed by commit rPc2f58496ad93 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

paste/

conduit/

ConduitAPI_paste_create_Method.php

40 lines

controller/

PhabricatorPasteEditController.php

10 lines

PhabricatorPasteViewController.php

16 lines

editor/

PhabricatorPasteEditor.php

83 lines

mail/

PasteCreateMailReceiver.php

23 lines

Diff 21289

View Options

src/applications/paste/conduit/ConduitAPI_paste_create_Method.php

View Options

src/applications/paste/controller/PhabricatorPasteEditController.php

View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

View Options

src/applications/paste/mail/PasteCreateMailReceiver.php

Make the paste "Create" transaction take a file PHID instead of contentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21289

src/applications/paste/conduit/ConduitAPI_paste_create_Method.php

src/applications/paste/controller/PhabricatorPasteEditController.php

src/applications/paste/controller/PhabricatorPasteViewController.php

src/applications/paste/editor/PhabricatorPasteEditor.php

src/applications/paste/mail/PasteCreateMailReceiver.php

Make the paste "Create" transaction take a file PHID instead of content
ClosedPublic
Actions

Revision Contents
Changeset List