Page MenuHomePhabricator
Differential D8969

Make the paste "Create" transaction take a file PHID instead of content
ClosedPublic
Actions

Authored by epriestley on May 3 2014, 11:35 PM.
Tags
None
Referenced Files
F15421510: D8969.id21289.diff
Sat, Mar 22, 12:26 AM
F15419843: D8969.id21274.diff
Fri, Mar 21, 9:21 AM
F15419543: D8969.id.diff
Fri, Mar 21, 6:55 AM
F15418473: D8969.diff
Thu, Mar 20, 11:32 PM
F15410495: D8969.diff
Wed, Mar 19, 7:30 AM
F15393309: D8969.diff
Sat, Mar 15, 8:47 PM
Unknown Object (File)
Mar 2 2025, 9:28 PM
Unknown Object (File)
Feb 12 2025, 4:24 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4814: Make paste edible
Commits
Restricted Diffusion Commit
rPc2f58496ad93: Make the paste "Create" transaction take a file PHID instead of content
Summary

Ref T4814. Although this approach made sense at one point, we have more file infrastructure now and T4814 will be easier if we just pass a PHID in.

Also swap Conduit over to use the Editor.

Test Plan
  • Created a paste.
  • Created a paste via Conduit.
  • Verified that files had correct permissions and appropriate object links in Files.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21274.May 3 2014, 11:35 PM
epriestley retitled this revision from to Make the paste "Create" transaction take a file PHID instead of content.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4814: Make paste edible.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 3 2014, 11:35 PM
Harbormaster completed remote builds in B224: Diff 21274.May 3 2014, 11:37 PM
epriestley updated this revision to Diff 21275.May 3 2014, 11:42 PM
  • Also you can create pastes via email apparently
Harbormaster completed remote builds in B225: Diff 21275.May 3 2014, 11:43 PM
btrahan accepted this revision.May 4 2014, 5:33 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 4 2014, 5:33 PM
epriestley closed this revision.May 4 2014, 6:11 PM
epriestley updated this revision to Diff 21289.

Closed by commit rPc2f58496ad93 (authored by @epriestley).

Revision Contents
Changeset List

Diff 21289

View Options

src/applications/paste/conduit/ConduitAPI_paste_create_Method.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteEditController.php

Loading...
View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

Loading...
View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...
View Options

src/applications/paste/mail/PasteCreateMailReceiver.php

Loading...
Phabricator · Built by Phacility