Page MenuHomePhabricator

Arcanst - add support for custom statuses to `arc close` workflow
ClosedPublic

Authored by btrahan on May 1 2014, 10:58 PM.
Tags
None
Referenced Files
F14401620: D8938.diff
Sun, Dec 22, 10:27 PM
Unknown Object (File)
Tue, Dec 17, 6:19 AM
Unknown Object (File)
Sat, Dec 14, 2:18 AM
Unknown Object (File)
Thu, Dec 5, 9:43 AM
Unknown Object (File)
Wed, Dec 4, 9:03 PM
Unknown Object (File)
Wed, Dec 4, 6:56 AM
Unknown Object (File)
Wed, Dec 4, 6:55 AM
Unknown Object (File)
Wed, Dec 4, 6:55 AM
Subscribers

Details

Summary

Fixes T4938. Now that we have customs statuses, this workflow needs to know about 'em.

One fun caveat is that Conduit isn't up and running to generate the help method, so I had to add a parameter to have the statuses list out. This could maybe be omitted since entering erroneous status options does indeed tell you the correct options.

Test Plan

arc close --list-status -- got a list of statuses
arc close T1 -- closed T1
arc close T1 -- error T1 closed already
arc close T1 -s foobar -- T1 status set to foobar

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Arcanst - add support for custom statuses to `arc close` workflow.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Seems pretty reasonable to me.

This revision is now accepted and ready to land.May 1 2014, 11:03 PM
btrahan edited edge metadata.

updated to querystatuses conduit method name

btrahan updated this revision to Diff 21210.

Closed by commit rARC96d34162186e (authored by @btrahan).

btrahan removed a task: Restricted Maniphest Task.May 1 2014, 11:14 PM