Reduce loudness of Inline Comments
ClosedPublic
Actions

Authored by chad on May 1 2014, 9:22 PM.

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rPf9c1bf9266b8: Reduce loudness of Inline Comments

Summary

Initially the intent was to mimic the property list headers but in practice this wasn't really needed. Reduced the caps and font weight. Left the icon for easy deliniation.

Test Plan

Review inline comments before and after change

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 21200.May 1 2014, 9:22 PM

chad retitled this revision from to Reduce loudness of Inline Comments.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptMay 1 2014, 9:22 PM

chad edited the test plan for this revision. (Show Details)May 1 2014, 9:23 PM

Harbormaster completed remote builds in B175: Diff 21200.May 1 2014, 9:24 PM

(I'm perfectly fine with either approach here, they haven't felt too heavy to me.)

This revision is now accepted and ready to land.May 1 2014, 9:37 PM

seen two minor quips in IRC, seemed reasonable to tone down.

Closed by commit rPf9c1bf9266b8 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

application/

diff/

inline-comment-summary.css

3 lines

Diff 21222

View Options

resources/celerity/map.php