For general consistency with Differential / other application searches. May look at "Cards" as the default view for everything.
Details
Details
- Reviewers
epriestley btrahan - Commits
- Restricted Diffusion Commit
rPda5f22172c57: Update Audit to use Cards in ObjectList
Reload my Audit page, easier to read and find status colors.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/audit/view/PhabricatorAuditListView.php | ||
|---|---|---|
| 81–82 | remove this and its good to ship also, not sure if you want this setFlush business or not | |
Comment Actions
Should we just make Cards the default and remove the non-card style? I don't know when I'm supposed to use one or the other.
Comment Actions
Generally the idea is they are "Objects", things that lead to an Object/Property List type view that you can then interact, and plain where its just a list of things/pages to visit, like Config. There are probably some styles we could consolidate here, as there's not a real need for so many.
| src/applications/audit/view/PhabricatorAuditListView.php | ||
|---|---|---|
| 81–82 | where do these get displayed? or they just aren't working? | |
| src/applications/audit/view/PhabricatorAuditListView.php | ||
|---|---|---|
| 81–82 | they get used for the homepage boxes IIRC. this buildList() method is something I added to not have setFlush and setCards, which both looked different than what Audit had before, and also keeping it looking the same on the home page. no need to setX twice, and I would personally be mislead into thinking buildList would not setCards(true) if I just saw it done (and little else) in render() | |