Differential D8931
Allow Remarkup lists to have checkboxes Authored by epriestley on May 1 2014, 8:10 PM. Tags None Referenced Files
Subscribers
Details
Fixes T3945. This provides a convenience style for checkmark lists. They're read-only. See disucssion in T3945. We're limited on how much we can style the checkboxes -- it would be nice to make them a little more visible, but this seems mostly OK to me. I added some hinting to the item text to make the completion state more clear.
Diff Detail
Event TimelineComment Actions Yeah, the only issue with browser checkboxes is they give the impression they should be interactive. You could use a font-icon here maybe, not sure how good those icons are though for this. Comment Actions Interesting feature. Are there any plans to have Maniphest task lists show up and have some "click to close" functionality right from the list? That's the only functional crash I can foresee (well, unless we get some lightweight "TODO" app or something too...) Comment Actions Let's see how sketchy this is with browser chrome. It basically has two issues:
But these issues fight one another, so maybe we end up somewhere reasonable. If not, we can switch to drawing our own obviously-not-interactable-but-prominent checkboxes (with icons or whatever else), but I think this element is relatively obscure. (I don't have any plans to make a more lightweight view of Maniphest tasks, but who knows. I wouldn't completely rule it out.) |