Page MenuHomePhabricator

Change spacing, layout of ObjectItem states
ClosedPublic

Authored by chad on May 1 2014, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 10:27 PM
Unknown Object (File)
Thu, Dec 12, 12:48 AM
Unknown Object (File)
Mon, Dec 9, 12:56 AM
Unknown Object (File)
Thu, Dec 5, 2:21 AM
Unknown Object (File)
Wed, Dec 4, 8:03 AM
Unknown Object (File)
Nov 12 2024, 2:19 AM
Unknown Object (File)
Nov 6 2024, 8:59 PM
Unknown Object (File)
Nov 3 2024, 10:26 AM
Subscribers

Details

Summary

A few tweaks:

  • Height in box is consistent now at 50px an Object
  • Divider/rule extends full width of box
  • Icon centers inside rule, box area.
Test Plan

Test UIExamples, check spacing with 4px grid in Photoshop. Test mobile/desktop layout of Harbormaster.

states.png (322×271 px, 27 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad retitled this revision from to Change spacing, layout of ObjectItem states.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.

If we still want to revert Harbormaster display, that's fine. My only concern in it's previous state is there isn't much indication on the state of the object, just a few colored pixels. For Chinese or Blind users, that would be problematic. Or worse likely if you are Color blind and Chinese. We should either add an attribute for pass/fail, or some iconography... or both. Setting the ObjectName to "PASS" would likely be enough, but you may want that for something else.

epriestley edited edge metadata.

I think we should back out Harbormaster for now, but agree that the list (and some other lists in other applications) needs work for the information which is communicated purely through color/iconography.

This revision is now accepted and ready to land.May 1 2014, 4:29 PM
chad updated this revision to Diff 21188.

Closed by commit rP1e6b2f26e92d (authored by @chad).