Page MenuHomePhabricator
Differential D8925

Allow users to provide alt text for image embeds
ClosedPublic
Actions

Authored by epriestley on May 1 2014, 2:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 10:11 PM
Unknown Object (File)
Fri, Apr 19, 3:35 AM
Unknown Object (File)
Fri, Apr 19, 3:35 AM
Unknown Object (File)
Fri, Apr 19, 3:35 AM
Unknown Object (File)
Tue, Apr 16, 7:01 AM
Unknown Object (File)
Fri, Apr 12, 7:56 AM
Unknown Object (File)
Fri, Apr 12, 7:56 AM
Unknown Object (File)
Fri, Apr 12, 7:55 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T4843: Making Phabricator accessible to assistive technologies
Commits
Restricted Diffusion Commit
rPc9dc554cb94f: Allow users to provide alt text for image embeds
Summary

Ref T4843.

  • Add an alt attribute so users can provide alternate text for {Fnnn}.
  • Add an alt attribute to image macros.
Test Plan

Embedded an image with alt and a macro, inspected HTML source to verify the alt attribute was present.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21178.May 1 2014, 2:08 PM
epriestley retitled this revision from to Allow users to provide alt text for image embeds.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T4843: Making Phabricator accessible to assistive technologies.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 1 2014, 2:08 PM
Harbormaster completed remote builds in B163: Diff 21178.May 1 2014, 2:09 PM
chad accepted this revision.May 1 2014, 2:13 PM
chad edited edge metadata.
chad added inline comments.
src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php
39

omg, memes for the blind.

This revision is now accepted and ready to land.May 1 2014, 2:13 PM
epriestley closed this revision.May 1 2014, 2:18 PM
epriestley updated this revision to Diff 21181.

Closed by commit rPc9dc554cb94f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
files/
remarkup/
5 lines
macro/
remarkup/
7 lines
docs/
user/
userguide/
3 lines

Diff 21181

View Options

src/applications/files/remarkup/PhabricatorRemarkupRuleEmbedFile.php

Loading...
View Options

src/applications/macro/remarkup/PhabricatorRemarkupRuleMeme.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
Phabricator · Built by Phacility