This makes the buildable list appear differently to everything else that uses application search. Having the buildable list inside a box is especially weird.

I think Harbormaster needs some kind of separate build status dashboard, but I don't know whether this can just be integrated into whatever dashboard configuration is planned for the home page.

These design changes were specific to solve several issues:

• Reduce visual clutter (remove unneeded horizontal lines)
• Provide stronger notice when something goes wrong
• Reduce height of the objects
• Provide visual distinction when combined with other ObjectLists on a page (i.e., dashboard homepage)

I'm not totally sold on this either, but am going to give it a bit more time and see if I get used to it. I think the Herald version of this element is much better than the older version, but it doesn't feel as good to me in Harbormaster, at least so far.

A vague sort of argument is that in Herald, the rules are parts-of-a-whole, but here they are not (buildables are often completely unrelated). This element renders them with strong visual cohesion, which makes them look closely related when they aren't.

I think these are reasonable concerns overall, I can likely address them in a follow up diff, will give it some thought. I'm mostly worried that extending the horizontal rules will reduce readability. That may be OK with the visual indicators we already have, though. Easy to mock out either way.

Overall, PHUIObjectItemListView was not really intended to be used everywhere for everything. It's ended up that way and generally been pretty good about the work we as it to do. It does come with a lot of visual clutter though that make it more taxing to find the information you need. I think moving forward if we like the component, we'll need to look at ways to reduce those that weight.

The original design was specifically for Workboards I believe.

I find PHUIObjectItemListView to be much easier to see individual buildables than the new structure. The padding of the new items means that overall the height of each item feels larger (compare https://secure.phabricator.com/harbormaster/ to https://code.redpointsoftware.com.au/harbormaster/).

Not to mention the top and bottom padding is uneven (uneven padding always drives me crazy).

I don't think the large icons particularly help; the coloured bars on the item list view actually provide enough distinction since everything else is gray or inattentive. So I still find it quite easy to see what's passed and what's failed on the old design.

So we've discussed options. I'm going to fix the padding and back out the changes to Harbormaster. We've agreed that "appSearch" should look like appSearch in all places. We're also going to Sprint on Dashboards, briefly today and more next week, which gives us a flexible way to design and fill content on any application homepage. This will allow people to set up Home, Differential, Projects, Harbormaster, anything, the way they wish to work (we'll have some reasonable defaults).