Page MenuHomePhabricator
Differential D8898

Unfatal rendering of repository policy transactions
ClosedPublic
Actions

Authored by epriestley on Apr 29 2014, 5:46 PM.
Tags
None
Referenced Files
F14059628: D8898.diff
Sun, Nov 17, 8:45 PM
F14052722: D8898.diff
Fri, Nov 15, 10:04 AM
F14045428: D8898.id21120.diff
Wed, Nov 13, 4:04 AM
F14034079: D8898.diff
Sat, Nov 9, 10:01 PM
F14016909: D8898.id21120.diff
Mon, Nov 4, 10:57 AM
F14016908: D8898.id21117.diff
Mon, Nov 4, 10:57 AM
F14016907: D8898.id.diff
Mon, Nov 4, 10:57 AM
F14014367: D8898.diff
Sun, Nov 3, 2:03 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4919: Unhandled Exception ("Exception")
Commits
Restricted Diffusion Commit
rP692a28b5b2df: Unfatal rendering of repository policy transactions
Summary

Fixes T4919. There's some special casing in Diffusion for CAN_PUSH right now, just accommodate that until things get more general.

Test Plan

Viewed a repository edit screen with a custom policy transaction. Clicked the link to view it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21117.Apr 29 2014, 5:46 PM
epriestley retitled this revision from to Unfatal rendering of repository policy transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4919: Unhandled Exception ("Exception").
Herald added a subscriber: epriestley. · View Herald TranscriptApr 29 2014, 5:46 PM
btrahan accepted this revision.Apr 29 2014, 5:47 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2014, 5:47 PM
Harbormaster completed remote builds in B126: Diff 21117.Apr 29 2014, 5:47 PM
epriestley closed this revision.Apr 29 2014, 5:57 PM
epriestley updated this revision to Diff 21120.

Closed by commit rP692a28b5b2df (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
4 lines
transactions/
controller/
5 lines
storage/
2 lines

Diff 21120

View Options

src/applications/repository/storage/PhabricatorRepositoryTransaction.php

Loading...
View Options

src/applications/transactions/controller/PhabricatorApplicationTransactionValueController.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility