Differential D8897

Make PhutilGitURI and PhutilURI strict about leading whitespace
ClosedPublic
Actions

Authored by epriestley on Apr 29 2014, 5:34 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T4913: Verify remote URI has URI nature when entered in Diffusion

Commits

rPHU1490f4fa10c8: Make PhutilGitURI and PhutilURI strict about leading whitespace

Summary

Fixes T4913. We silently accept git and normal URIs with leading spaces, but other systems will not accept these. Instead, fail to parse these so they don't get into the system if we're validating URIs.

Test Plan

Screen_Shot_2014-04-29_at_10.33.52_AM.png (956×1 px, 122 KB)

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21113.Apr 29 2014, 5:34 PM

epriestley retitled this revision from to Make PhutilGitURI and PhutilURI strict about leading whitespace.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4913: Verify remote URI has URI nature when entered in Diffusion.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 29 2014, 5:34 PM

Harbormaster completed remote builds in B124: Diff 21113.Apr 29 2014, 5:35 PM

Ah - thanks for discussion in T4913.

This revision is now accepted and ready to land.Apr 29 2014, 5:47 PM

Closed by commit rPHU1490f4fa10c8 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilGitURI.php

6 lines

PhutilURI.php

9 lines

__tests__/

PhutilGitURITestCase.php

5 lines

PhutilURITestCase.php

5 lines

Diff 21121

View Options

src/parser/PhutilGitURI.php

View Options

src/parser/PhutilURI.php

View Options

src/parser/tests/PhutilGitURITestCase.php

View Options

src/parser/tests/PhutilURITestCase.php

Make PhutilGitURI and PhutilURI strict about leading whitespaceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 21121

src/parser/PhutilGitURI.php

src/parser/PhutilURI.php

src/parser/__tests__/PhutilGitURITestCase.php

src/parser/__tests__/PhutilURITestCase.php

Make PhutilGitURI and PhutilURI strict about leading whitespace
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/PhutilGitURITestCase.php

src/parser/tests/PhutilURITestCase.php