Differential D8893

Add Success/Fail states to PHUIObjectList
ClosedPublic
Actions

Authored by chad on Apr 29 2014, 4:16 PM.

Tags

None

Referenced Files

	F18319291: D8893.id21106.diff
	Sun, Aug 24, 12:28 PM

	F18313117: D8893.id21100.diff
	Sun, Aug 24, 6:39 AM

	F18134044: D8893.id21107.diff
	Wed, Aug 13, 11:34 PM

	F18133440: D8893.id21107.diff
	Wed, Aug 13, 10:57 PM

	F18113706: D8893.id.diff
	Wed, Aug 13, 2:54 AM

	F18092780: D8893.id21106.diff
	Thu, Aug 7, 1:00 PM

	F18092779: D8893.id21107.diff
	Thu, Aug 7, 1:00 PM

	F18092778: D8893.id21100.diff
	Thu, Aug 7, 1:00 PM

Subscribers

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rPcafd2dd6cb4e: Add Success/Fail states to PHUIObjectList

Summary

A number of interfaces could use a more consice looking ObjectItemList for showing pass/fail/warn states.

Added a new "State" for PHUIObjectItemListView
Updated UIExamples
Implemented in Herald (next Harmormaster)

Test Plan

UIExamples / Herald, desktop and mobile

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 21100.Apr 29 2014, 4:16 PM

chad retitled this revision from to Add Success/Fail states to PHUIObjectList.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptApr 29 2014, 4:16 PM

Harbormaster completed remote builds in B115: Diff 21100.Apr 29 2014, 4:17 PM

undefined (305×358 px, 39 KB)

undefined (646×488 px, 89 KB)

epriestley accepted this revision.Apr 29 2014, 5:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 29 2014, 5:12 PM

remove white class

Closed by commit rPcafd2dd6cb4e (authored by @chad).

Harbormaster completed remote builds in B119: Diff 21106.Apr 29 2014, 5:15 PM

Harbormaster brought me here. =D

src/view/phui/PHUIObjectItemListView.php
66	if $states should always be an array, its worth typehinting array setStates(array $states) and then PHP will error if $states is some non-array value. This is also nice documentation. Note if $states should be null sometimes you could do setStates(array $states = null) ...there's also assert_instances_of($states, 'classStatesShouldBe') if you really want to be hardcore here.

it's bool, as in show the list as a list of states, maybe a better setX name...

whoops, lol. I blame harbormaster.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

herald/

controller/

HeraldTranscriptController.php

55 lines

uiexample/

controller/

PhabricatorUIExampleRenderController.php

3 lines

examples/

PHUIObjectItemListExample.php

44 lines

view/

phui/

PHUIObjectItemListView.php

9 lines

PHUIObjectItemView.php

48 lines

webroot/

rsrc/

css/

phui/

phui-object-item-list-view.css

38 lines

Diff 21107

resources/celerity/map.php

Loading...

src/applications/herald/controller/HeraldTranscriptController.php

Loading...

src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php

Loading...

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...

src/view/phui/PHUIObjectItemListView.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...