Page MenuHomePhabricator

Make two-factor auth actually work
ClosedPublic

Authored by epriestley on Apr 28 2014, 5:03 PM.

Details

Summary

Ref T4398. Allows auth factors to render and validate when prompted to take a hi-sec action.

This has a whole lot of rough edges still (see D8875) but does fundamentally work correctly.

Test Plan
  • Added two different TOTP factors to my account for EXTRA SECURITY.
  • Took hisec actions with no auth factors, and with attached auth factors.
  • Hit all the error/failure states of the hisec entry process.
  • Verified hisec failures appear in activity logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21080.Apr 28 2014, 5:03 PM
epriestley retitled this revision from to Make two-factor auth actually work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.

My account is secure to the max!!

btrahan accepted this revision.Apr 28 2014, 5:14 PM
btrahan edited edge metadata.

Macro epriestleyweddingcake: false topper lyuba at comp too

This revision is now accepted and ready to land.Apr 28 2014, 5:14 PM
epriestley closed this revision.Apr 28 2014, 5:20 PM
epriestley updated this revision to Diff 21081.

Closed by commit rPa017a8e02b51 (authored by @epriestley).