Page MenuHomePhabricator

Fix for showing an unregistered author name in the tooltip of diffusion revision link
ClosedPublic

Authored by kylejao on Apr 26 2014, 7:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:15 PM
Unknown Object (File)
Wed, Apr 17, 8:23 PM
Unknown Object (File)
Thu, Apr 11, 10:53 AM
Unknown Object (File)
Apr 4 2024, 12:11 PM
Unknown Object (File)
Mar 31 2024, 11:09 AM
Unknown Object (File)
Mar 13 2024, 10:33 AM
Unknown Object (File)
Mar 12 2024, 1:39 AM
Unknown Object (File)
Mar 12 2024, 1:39 AM
Subscribers

Details

Summary

When showing contents of a file with the blame mode enabled, tooltips pops out
when the mouse hovers over previous commit linkes on left side. The last part of the
tooltips is the author's name. If an author is unregistered, the name becomes
<span>name</span>.

before.png (144×1 px, 42 KB)

This doesn't happen if the author is registered.

Test Plan

Check tooltips after making the change.
{F147725}

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kylejao retitled this revision from to Fix for showing an unregistered author name in the tooltip of diffusion revision link.
kylejao updated this object.
kylejao edited the test plan for this revision. (Show Details)
kylejao added a reviewer: epriestley.
kylejao edited the test plan for this revision. (Show Details)
kylejao edited edge metadata.

This solves the problem but not sure if this creates other problems.

epriestley edited edge metadata.

I think this could be cleaned up a bit in general (it looks like $author_link is never used when there's a handle) but I think this is a reasonable fix until the next time there are bigger changes here. Thanks!

This revision is now accepted and ready to land.Apr 26 2014, 7:51 PM
epriestley updated this revision to Diff 21044.

Closed by commit rPe8c6c81b6ea4 (authored by @kylejao, committed by @epriestley).

Thanks for your suggestion. It's my first time contributing to an open sourced project, so feel a bit hesitate. Lol