Page MenuHomePhabricator

Improve clarity around Remarkup blockquote display
ClosedPublic

Authored by chad on Apr 26 2014, 5:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 4, 6:59 PM
Unknown Object (File)
Wed, Sep 4, 4:15 AM
Unknown Object (File)
Mon, Sep 2, 3:54 AM
Unknown Object (File)
Sun, Sep 1, 11:02 PM
Unknown Object (File)
Sat, Aug 31, 10:11 AM
Unknown Object (File)
Sun, Aug 25, 10:13 PM
Unknown Object (File)
Sun, Aug 25, 12:09 AM
Unknown Object (File)
Sun, Aug 18, 12:18 PM
Subscribers

Details

Summary

This provides a little more separation/clarify around the blockquote design.

Test Plan

Find a verbose passage from @epriestley, apply style.

Screen_Shot_2014-04-26_at_10.35.03_AM.png (1×1 px, 247 KB)

Screen_Shot_2014-04-26_at_10.34.51_AM.png (1×1 px, 256 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad retitled this revision from to Improve clarity around Remarkup blockquote display.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a subscriber: epriestley.
epriestley edited edge metadata.

Maybe drop the indent? The padding and background fill are great, but when a reply is un-dented compared to a quote it's weird to my eye.

This revision is now accepted and ready to land.Apr 26 2014, 7:29 PM
chad edited edge metadata.
  • Update spacing
chad updated this revision to Diff 21039.

Closed by commit rP7492bbeff70e (authored by @chad).