Page MenuHomePhabricator

Fix an issue with embedding slowvotes
ClosedPublic

Authored by epriestley on Apr 23 2014, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 2, 2:24 AM
Unknown Object (File)
Sun, Jul 31, 7:01 PM
Unknown Object (File)
Sun, Jul 31, 3:31 PM
Unknown Object (File)
Jul 12 2022, 8:52 PM
Unknown Object (File)
Jul 11 2022, 6:23 AM
Unknown Object (File)
Jun 11 2022, 1:56 AM
Unknown Object (File)
Jun 7 2022, 5:31 AM
Unknown Object (File)
May 30 2022, 10:52 AM

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP3b5883d8c1ee: Fix an issue with embedding slowvotes
Summary

In some applications, using {V2} syntax to embed a vote throws. The chain of causality looks like this:

  • We try to render a phabricator_form().
  • This requires a CSRF token.
  • We look for a CSRF token on the user.
  • It's an omnipotent user with no token, so everything fails.

To resolve this, make sure we always pass the real user in.

Test Plan
  • Lots of grep.
  • Made a Differential comment with {V2}.
  • Made a Diffusion comment with {V2}.
  • Made a Maniphest comment with {V2}.
  • Replied to a Conpherence thread with {V2}.
  • Created a Conpherence thread with {V2}.
  • Used Conduit to update a Conpherence thread with {V2}.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix an issue with embedding slowvotes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: lpriestley.
This revision is now accepted and ready to land.Apr 23 2014, 11:30 PM
epriestley updated this revision to Diff 21001.

Closed by commit rP3b5883d8c1ee (authored by @epriestley).