Page MenuHomePhabricator
Differential D8847

Clarify STRICT_ALL_TABLES instructions
ClosedPublic
Actions

Authored by epriestley on Apr 23 2014, 7:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 10:09 PM
Unknown Object (File)
Sun, Dec 22, 10:09 PM
Unknown Object (File)
Wed, Dec 18, 12:18 PM
Unknown Object (File)
Sat, Dec 7, 4:40 PM
Unknown Object (File)
Sat, Dec 7, 11:10 AM
Unknown Object (File)
Sun, Dec 1, 1:28 AM
Unknown Object (File)
Nov 29 2024, 9:12 AM
Unknown Object (File)
Nov 21 2024, 1:51 AM
View All Files
Subscribers
epriestley
sophiebits

Details

Reviewers
btrahan
csilvers
Commits
Restricted Diffusion Commit
rP67f015a76c79: Clarify STRICT_ALL_TABLES instructions
Summary
  • Mention the [mysqld] section.
  • Should be sql_mode, not sql-mode.
  • Improve clarity of the text.
  • Slightly nicer markup.
Test Plan

Screen_Shot_2014-04-23_at_12.37.46_PM.png (1×1 px, 153 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20987.Apr 23 2014, 7:38 PM
epriestley retitled this revision from to Clarify STRICT_ALL_TABLES instructions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, csilvers.
Herald added subscribers: sophiebits, epriestley. · View Herald TranscriptApr 23 2014, 7:38 PM
Harbormaster completed remote builds in B50: Diff 20987.Apr 23 2014, 7:39 PM
epriestley updated this revision to Diff 20988.Apr 23 2014, 7:39 PM
  • Give sql_mode nice formatting too.
Harbormaster completed remote builds in B51: Diff 20988.Apr 23 2014, 7:40 PM
btrahan accepted this revision.Apr 23 2014, 7:44 PM
btrahan edited edge metadata.

Bug report - if you click the "harbormaster build" notification, you go to harbormaster as expected, but the notification count doesn't decrement and the notification doesn't clear.

This revision is now accepted and ready to land.Apr 23 2014, 7:44 PM
csilvers edited edge metadata.Apr 23 2014, 7:47 PM

Thanks! FWIW, I haven't gotten this to work yet (though I was editing a different config file than my.cnf, so I don't yet assume that the instructions here are still problematic).

One question I still have: is it necessary to restart mysqld after making this chagne? I assume so, but you may want to mention that explicitly.

epriestley updated this revision to Diff 20989.Apr 23 2014, 7:49 PM
epriestley edited edge metadata.
  • Mention restarting.

I'll hold this until you actually get it working in case these turn out to be the worst instructions ever written or whatever.

Harbormaster completed remote builds in B52: Diff 20989.Apr 23 2014, 7:50 PM
csilvers added a comment.Apr 23 2014, 8:02 PM

OK, following the instructions works. It looks like the problem was with permissions on my new .cnf file. (They were too generous? I can't find an error message, sigh. I'm rambling.)

epriestley closed this revision.Apr 23 2014, 8:05 PM
epriestley updated this revision to Diff 20990.

Closed by commit rP67f015a76c79 (authored by @epriestley).

csilvers added a comment.Apr 23 2014, 8:08 PM

(Turns out it was an apparmor issue. Aaargh!)

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
27 lines

Diff 20990

View Options

src/applications/config/check/PhabricatorSetupCheckMySQL.php

Loading...
Phabricator · Built by Phacility