Page MenuHomePhabricator

Project - add editor-level support for detecting name conflicts
ClosedPublic

Authored by btrahan on Apr 21 2014, 10:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 25, 6:03 PM
Unknown Object (File)
Tue, Feb 25, 6:03 PM
Unknown Object (File)
Sun, Feb 9, 12:24 PM
Unknown Object (File)
Sun, Feb 9, 12:24 PM
Unknown Object (File)
Sun, Feb 9, 12:24 PM
Unknown Object (File)
Sun, Feb 9, 12:24 PM
Unknown Object (File)
Thu, Feb 6, 7:22 PM
Unknown Object (File)
Thu, Feb 6, 6:41 PM
Subscribers

Details

Summary

Fixes T4833. I wish there was an elegant way to catch this exception but I think the stack is written such that we really should just do this one-off query here...

Test Plan

from the "create project" link under "edit task" I received a more detailed exception than the report in T4833 post patch. I also tested editing an existing project - yay - and editing an existing project to some other existing project's name - got a nice error dialogue.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Project - add editor-level support for detecting name conflicts.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

T4021 is on my mid-term radar and I can try to give us proper hooks for this kind of thing then. This is a good step forward, though.

This revision is now accepted and ready to land.Apr 21 2014, 10:43 PM
btrahan updated this revision to Diff 20964.

Closed by commit rPc00733a292e8 (authored by @btrahan).