Page MenuHomePhabricator
Differential D8833

Censor URIs in service profile log
ClosedPublic
Actions

Authored by epriestley on Apr 21 2014, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 16, 6:24 PM
Unknown Object (File)
Wed, Sep 4, 4:42 PM
Unknown Object (File)
Sun, Sep 1, 10:53 AM
Unknown Object (File)
Sat, Aug 31, 3:11 PM
Unknown Object (File)
Aug 19 2024, 7:15 AM
Unknown Object (File)
Aug 18 2024, 5:23 PM
Unknown Object (File)
Aug 15 2024, 8:08 AM
Unknown Object (File)
Aug 9 2024, 11:59 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
rPHU0199100a9b6d: Censor URIs in service profile log
Summary

Mailgun requests can hit a credentialed URI. Censor credentials from --trace URIs.

Test Plan

Ran bin/mail send-test ... --trace and saw censored credentials.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20956.Apr 21 2014, 9:43 PM
epriestley retitled this revision from to Censor URIs in service profile log.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2014, 9:43 PM
Harbormaster completed remote builds in B35: Diff 20956.Apr 21 2014, 9:44 PM
btrahan accepted this revision.Apr 21 2014, 10:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2014, 10:40 PM
epriestley closed this revision.Apr 21 2014, 10:44 PM
epriestley updated this revision to Diff 20963.

Closed by commit rPHU0199100a9b6d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
serviceprofiler/
2 lines

Diff 20963

View Options

src/serviceprofiler/PhutilServiceProfiler.php

Loading...
Phabricator · Built by Phacility