Paths

Table of Contentst

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"
ClosedPublic
Actions

Authored by epriestley on Apr 18 2014, 11:41 PM.

Tags

None

Referenced Files

	F15438463: D8814.id20915.diff
	Wed, Mar 26, 12:49 AM

	F15437649: D8814.id.diff
	Tue, Mar 25, 8:48 PM

	F15436634: D8814.id20918.diff
	Tue, Mar 25, 3:37 PM

	F15433110: D8814.diff
	Mon, Mar 24, 9:25 PM

	F15433048: D8814.id20914.diff
	Mon, Mar 24, 9:07 PM

	F15432458: D8814.id20914.diff
	Mon, Mar 24, 6:15 PM

	F15393768: D8814.id20915.diff
	Sat, Mar 15, 11:06 PM

	F15393766: D8814.id20914.diff
	Sat, Mar 15, 11:06 PM

View All Files

Subscribers

epriestley

zeeg

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP71ef48b3e519: When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Summary

This %d should be a %s, since the PhutilNumber value may get formatted according to locale settings.

Test Plan

will make @zeeg

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20914.Apr 18 2014, 11:41 PM

epriestley retitled this revision from to When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a subscriber: zeeg.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2014, 11:41 PM

Also fix the translations.

Harbormaster completed remote builds in B9: Diff 20914.Apr 18 2014, 11:42 PM

Harbormaster completed remote builds in B10: Diff 20915.

btrahan accepted this revision.Apr 19 2014, 12:24 AM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 19 2014, 12:24 AM

Closed by commit rP71ef48b3e519 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

2 lines

infrastructure/

internationalization/

translation/

PhabricatorBaseEnglishTranslation.php

6 lines

Diff 20918

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php