Page MenuHomePhabricator
Differential D8804

Link to Herald transcripts from Herald transactions
ClosedPublic
Actions

Authored by epriestley on Apr 17 2014, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:13 AM
Unknown Object (File)
Thu, Apr 11, 8:50 AM
Unknown Object (File)
Thu, Apr 11, 8:50 AM
Unknown Object (File)
Thu, Apr 11, 8:49 AM
Unknown Object (File)
Thu, Apr 11, 8:49 AM
Unknown Object (File)
Thu, Apr 11, 7:01 AM
Unknown Object (File)
Thu, Apr 11, 6:56 AM
Unknown Object (File)
Sat, Apr 6, 9:32 AM
View All Files
Subscribers
dctrwatson
epriestley
Tokens
"Mountain of Wealth" token, awarded by dctrwatson.

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPb5df5af04dde: Link to Herald transcripts from Herald transactions
Summary

See IRC. Some users are having difficulty figuring out why Herald is taking some actions. Make it easier to get to the transcript.

Test Plan

Screen_Shot_2014-04-17_at_1.15.01_PM.png (68×460 px, 12 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20886.Apr 17 2014, 8:16 PM
epriestley retitled this revision from to Link to Herald transcripts from Herald transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a reviewer: chad.Apr 17 2014, 8:16 PM
Herald added a subscriber: epriestley.
epriestley updated this revision to Diff 20887.Apr 17 2014, 8:16 PM
epriestley edited edge metadata.
  • Celerity map after lint.
chad added inline comments.Apr 17 2014, 8:33 PM
webroot/rsrc/css/aphront/transaction.css
65 ↗(On Diff #20887)

thank you.

chad accepted this revision.Apr 17 2014, 8:33 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 17 2014, 8:33 PM
epriestley added inline comments.Apr 17 2014, 8:37 PM
webroot/rsrc/css/aphront/transaction.css
65 ↗(On Diff #20887)

haha, did I do something good/bad here? :P

chad added a comment.Apr 17 2014, 8:39 PM

You cared about design❗️

epriestley added a comment.Apr 17 2014, 8:39 PM

(Looking at it, I think that's actually not the best CSS file -- it looks like phabricator-transaction-view-css is only used by Diffusion to render its janky old transactions. Let me see if I can find a better place for that rule.)

chad added a comment.Apr 17 2014, 8:39 PM

( T_T)＼(^-^ )

epriestley updated this revision to Diff 20888.Apr 17 2014, 8:41 PM
epriestley edited edge metadata.
  • Find a better home for the CSS rule.
epriestley closed this revision.Apr 17 2014, 10:57 PM
epriestley updated this revision to Diff 20891.

Closed by commit rPb5df5af04dde (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
transactions/
editor/
5 lines
storage/
15 lines
view/
24 lines
webroot/
rsrc/
css/
phui/
6 lines

Diff 20891

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility