Page MenuHomePhabricator

Improve robustnesss of feed text rendering
ClosedPublic

Authored by epriestley on Apr 16 2014, 8:29 PM.
Tags
None
Referenced Files
F15434002: D8793.diff
Tue, Mar 25, 1:30 AM
F15428765: D8793.id20890.diff
Sun, Mar 23, 10:13 PM
F15385313: D8793.diff
Fri, Mar 14, 10:14 PM
Unknown Object (File)
Feb 24 2025, 11:40 AM
Unknown Object (File)
Feb 16 2025, 5:17 AM
Unknown Object (File)
Feb 16 2025, 12:23 AM
Unknown Object (File)
Feb 12 2025, 12:46 AM
Unknown Object (File)
Feb 11 2025, 11:56 PM

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPe49251ec9804: Improve robustnesss of feed text rendering
Summary

Couple of minor cleanup things here:

  • Pass handles to ApplicationTransactions when rendering their stories; this happened implicitly before but doesn't now.
  • Add ?text=1 to do ad-hoc rendering of a story in text mode.
  • Make Conduit skip unrenderable stories.
  • Fix/modernize some text in the Commit story.
Test Plan

Rendered text versions of stories via Conduit and ?text=1.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Improve robustnesss of feed text rendering.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added subscribers: sophiebits, zeeg.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Apr 16 2014, 9:19 PM
epriestley updated this revision to Diff 20890.

Closed by commit rPe49251ec9804 (authored by @epriestley).