Paths

Table of Contentst

Differential D8793

Improve robustnesss of feed text rendering
ClosedPublic
Actions

Authored by epriestley on Apr 16 2014, 8:29 PM.

Tags

None

Referenced Files

	F14834160: D8793.id.diff
	Thu, Jan 30, 2:18 PM

	Unknown Object (File)
	Tue, Jan 28, 11:29 PM

	Unknown Object (File)
	Tue, Jan 28, 6:31 AM

	Unknown Object (File)
	Sat, Jan 25, 8:58 AM

	Unknown Object (File)
	Fri, Jan 24, 5:26 AM

	Unknown Object (File)
	Thu, Jan 16, 3:09 PM

	Unknown Object (File)
	Wed, Jan 15, 6:34 PM

	Unknown Object (File)
	Wed, Jan 15, 6:34 PM

Subscribers

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPe49251ec9804: Improve robustnesss of feed text rendering

Summary

Couple of minor cleanup things here:

Pass handles to ApplicationTransactions when rendering their stories; this happened implicitly before but doesn't now.
Add ?text=1 to do ad-hoc rendering of a story in text mode.
Make Conduit skip unrenderable stories.
Fix/modernize some text in the Commit story.

Test Plan

Rendered text versions of stories via Conduit and ?text=1.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20866.Apr 16 2014, 8:29 PM

epriestley retitled this revision from to Improve robustnesss of feed text rendering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added subscribers: sophiebits, zeeg.

Herald added a subscriber: epriestley.Apr 16 2014, 8:29 PM

chad accepted this revision.Apr 16 2014, 9:19 PM

chad added a reviewer: chad.

This revision is now accepted and ready to land.Apr 16 2014, 9:19 PM

Closed by commit rPe49251ec9804 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

aphront/

response/

AphrontPlainTextResponse.php

2 lines

applications/

feed/

conduit/

ConduitAPI_feed_query_Method.php

9 lines

controller/

PhabricatorFeedDetailController.php

6 lines

story/

PhabricatorFeedStoryCommit.php

12 lines

transactions/

feed/

PhabricatorApplicationTransactionFeedStory.php

1 line

Diff 20890

src/aphront/response/AphrontPlainTextResponse.php

Loading...

src/applications/feed/conduit/ConduitAPI_feed_query_Method.php

Loading...

src/applications/feed/controller/PhabricatorFeedDetailController.php

Loading...

src/applications/feed/story/PhabricatorFeedStoryCommit.php

Loading...

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

Loading...