Page MenuHomePhabricator
Differential D8767

Unban releeph product name "branch"
ClosedPublic
Actions

Authored by epriestley on Apr 13 2014, 12:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 7:28 AM
Unknown Object (File)
Sun, Dec 8, 3:12 AM
Unknown Object (File)
Thu, Dec 5, 8:13 PM
Unknown Object (File)
Thu, Dec 5, 8:13 PM
Unknown Object (File)
Wed, Dec 4, 12:47 PM
Unknown Object (File)
Thu, Nov 28, 11:56 AM
Unknown Object (File)
Wed, Nov 27, 10:16 PM
Unknown Object (File)
Tue, Nov 26, 7:49 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP05e30a024d86: Unban releeph product name "branch"
Summary

Fixes T3657. We no longer construct ambiguous URIs, so product names are no longer restricted.

Also fix some minor URI construction stuff.

Test Plan

Created a product called "branch".

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20794.Apr 13 2014, 12:13 AM
epriestley retitled this revision from to Unban releeph product name "branch".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley.Apr 13 2014, 12:13 AM
btrahan accepted this revision.Apr 14 2014, 12:45 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2014, 12:45 AM
epriestley closed this revision.Apr 14 2014, 7:07 PM
epriestley updated this revision to Diff 20809.

Closed by commit rP05e30a024d86 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
releeph/
application/
2 lines
controller/
branch/
4 lines
16 lines
storage/
19 lines

Diff 20809

View Options

src/applications/releeph/application/PhabricatorApplicationReleeph.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchCreateController.php

Loading...
View Options

src/applications/releeph/controller/branch/ReleephBranchViewController.php

Loading...
View Options

src/applications/releeph/storage/ReleephProject.php

Loading...
Phabricator · Built by Phacility