Page MenuHomePhabricator

Put rel="noreferrer" on all nonlocal links
ClosedPublic

Authored by epriestley on Apr 6 2014, 2:56 PM.
Tags
None
Referenced Files
F15427717: D8711.id20657.diff
Sun, Mar 23, 3:46 PM
F15423318: D8711.id.diff
Sat, Mar 22, 2:46 PM
F15408416: D8711.id.diff
Tue, Mar 18, 10:54 PM
F15400714: D8711.diff
Mon, Mar 17, 1:31 PM
F15378597: D8711.diff
Thu, Mar 13, 3:39 PM
Unknown Object (File)
Feb 24 2025, 11:39 AM
Unknown Object (File)
Feb 9 2025, 12:11 PM
Unknown Object (File)
Feb 9 2025, 12:11 PM
Subscribers

Details

Summary

Ref T4342. By default, insert rel="noreferrer" for links. We do not insert this if:

  • The caller provided an explicit "rel" attribute.
  • We recognize the link as an anchor ("#comment-2"), or as local to the current domain ("/path/to/resource").

Otherwise, add it in all cases.

Test Plan

Added and executed unit tests. (The javascript stuff which was touched a little bit has a pile of tests already, too.)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Put rel="noreferrer" on all nonlocal links.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2014, 5:16 PM
epriestley updated this revision to Diff 20671.

Closed by commit rPHUfd6f1829e353 (authored by @epriestley).