Don't show 'needs review' on DifferentialObjects
ClosedPublic
Actions

Authored by chad on Apr 4 2014, 8:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 3:12 PM

	Unknown Object (File)
	Sun, Apr 14, 12:30 PM

	Unknown Object (File)
	Fri, Apr 5, 11:35 PM

	Unknown Object (File)
	Tue, Apr 2, 5:15 PM

	Unknown Object (File)
	Wed, Mar 27, 4:56 PM

	Unknown Object (File)
	Fri, Mar 22, 11:53 PM

	Unknown Object (File)
	Fri, Mar 22, 11:53 PM

	Unknown Object (File)
	Fri, Mar 22, 11:09 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP3b33089de7f6: Don't show 'needs review' on DifferentialObjects

Summary

This text is overly repetitive and is not super important. Keeps the other states. Also

Easier to parse reviewers now
Mobile is less janky

Test Plan

reload my list of diffs

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

chad updated this revision to Diff 20652.Apr 4 2014, 8:55 PM

chad retitled this revision from to Don't show 'needs review' on DifferentialObjects.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley.Apr 4 2014, 8:55 PM

chad edited the test plan for this revision. (Show Details)Apr 4 2014, 8:55 PM

epriestley accepted this revision.Apr 4 2014, 8:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 4 2014, 8:59 PM

Closed by commit rP3b33089de7f6 (authored by @chad).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

view/

DifferentialRevisionListView.php

5 lines

Diff 20653

View Options

src/applications/differential/view/DifferentialRevisionListView.php

Don't show 'needs review' on DifferentialObjectsClosedPublicActions