Page MenuHomePhabricator

Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator
ClosedPublic

Authored by epriestley on Mar 31 2014, 7:45 PM.
Tags
None
Referenced Files
F18107157: D8658.diff
Sun, Aug 10, 11:43 PM
F18092529: D8658.id20541.diff
Thu, Aug 7, 11:09 AM
F18036376: D8658.id20530.diff
Sun, Aug 3, 1:54 AM
F17921854: D8658.id.diff
Wed, Jul 30, 5:56 AM
F17893944: D8658.diff
Tue, Jul 29, 5:21 AM
F17880133: D8658.id.diff
Mon, Jul 28, 9:13 PM
Unknown Object (File)
Jun 29 2025, 4:20 AM
Unknown Object (File)
May 29 2025, 7:57 AM
Subscribers

Details

Summary

Fixes T4649. The issue in that task is caused because we're submitting a block of text including comments. We've probably been doing this for a long time, but maybe were more liberal in parsing before. Instead, strip them.

Test Plan

Ran arc diff --verbatim and got "Dxxx" prefilled correctly.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:43 PM
epriestley updated this revision to Diff 20541.

Closed by commit rARC5280f3708ef7 (authored by @epriestley).