Page MenuHomePhabricator

Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator
ClosedPublic

Authored by epriestley on Mar 31 2014, 7:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 11 2024, 12:00 PM
Unknown Object (File)
Feb 4 2024, 7:02 PM
Unknown Object (File)
Feb 4 2024, 7:02 PM
Unknown Object (File)
Feb 4 2024, 7:02 PM
Unknown Object (File)
Feb 4 2024, 7:02 PM
Unknown Object (File)
Jan 27 2024, 11:49 PM
Unknown Object (File)
Jan 16 2024, 7:14 PM
Unknown Object (File)
Jan 16 2024, 7:08 AM
Subscribers

Details

Summary

Fixes T4649. The issue in that task is caused because we're submitting a block of text including comments. We've probably been doing this for a long time, but maybe were more liberal in parsing before. Instead, strip them.

Test Plan

Ran arc diff --verbatim and got "Dxxx" prefilled correctly.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Strip comments during `arc diff --verbatim` workflow before submitting to Phabricator.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 31 2014, 9:43 PM
epriestley updated this revision to Diff 20541.

Closed by commit rARC5280f3708ef7 (authored by @epriestley).