Page MenuHomePhabricator
Differential D8651

Normalize token line height
ClosedPublic
Actions

Authored by chad on Mar 30 2014, 8:22 PM.
Tags
None
Referenced Files
F14042839: D8651.diff
Tue, Nov 12, 6:32 AM
F14025423: D8651.diff
Thu, Nov 7, 5:44 PM
F14010039: D8651.id20514.diff
Thu, Oct 31, 3:25 AM
F14003476: D8651.id20514.diff
Sat, Oct 26, 6:35 AM
F14002192: D8651.diff
Fri, Oct 25, 4:09 PM
F13993840: D8651.id20514.diff
Wed, Oct 23, 1:46 AM
Unknown Object (File)
Oct 1 2024, 6:27 PM
Unknown Object (File)
Sep 23 2024, 12:36 AM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPa1d6fe379b58: Normalize token line height
Summary

This resolves mysterious extra space below tokens in property list view and timeline view.

Test Plan

Check Property List in Phriction, Timeline examples, Token Application, and giving my fake accounts tokens.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

chad updated this revision to Diff 20513.Mar 30 2014, 8:22 PM
chad retitled this revision from to Normalize token line height.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: chad, Korvin, epriestley.Mar 30 2014, 8:22 PM
chad added a comment.Mar 30 2014, 8:23 PM

undefined (180×244 px, 20 KB)

undefined (186×267 px, 21 KB)

epriestley accepted this revision.Mar 30 2014, 9:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2014, 9:54 PM
chad closed this revision.Mar 30 2014, 10:22 PM
chad updated this revision to Diff 20514.

Closed by commit rPa1d6fe379b58 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
14 lines
webroot/
rsrc/
css/
application/
tokens/
8 lines
phui/
2 lines
4 lines

Diff 20514

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/tokens/tokens.css

Loading...
View Options

webroot/rsrc/css/phui/phui-icon.css

Loading...
View Options

webroot/rsrc/css/phui/phui-timeline-view.css

Loading...
Phabricator · Built by Phacility