Page MenuHomePhabricator
Differential D8634

Use ApplicationTransactions for Releeph product activity
ClosedPublic
Actions

Authored by epriestley on Mar 28 2014, 12:53 PM.
Tags
None
Referenced Files
F13344013: D8634.diff
Fri, Jun 21, 6:33 AM
F13332139: D8634.diff
Mon, Jun 17, 8:37 AM
F13310971: D8634.diff
Mon, Jun 10, 10:24 PM
F13261709: D8634.diff
May 27 2024, 1:21 AM
F13257371: D8634.id20496.diff
May 25 2024, 11:56 PM
F13257370: D8634.id20475.diff
May 25 2024, 11:56 PM
F13219685: D8634.id20475.diff
May 18 2024, 8:00 PM
F13192082: D8634.id.diff
May 12 2024, 4:58 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPc7bcecb9b0e9: Use ApplicationTransactions for Releeph product activity
Summary

Ref T3549. Ref T3663.

  • Use transactions for activate/deactivate.
  • Rename some "project" -> "product".
Test Plan
  • Activated products.
  • Deactivated products.

Screen_Shot_2014-03-28_at_5.51.34_AM.png (695×1 px, 102 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20475.Mar 28 2014, 12:53 PM
epriestley retitled this revision from to Use ApplicationTransactions for Releeph product activity.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: Restricted Maniphest Task, Restricted Maniphest Task.
Herald added a subscriber: epriestley.Mar 28 2014, 12:53 PM
btrahan accepted this revision.Mar 28 2014, 8:09 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/releeph/controller/project/ReleephProductHistoryController.php
3

aye, thar she blows

This revision is now accepted and ready to land.Mar 28 2014, 8:09 PM
epriestley closed this revision.Mar 29 2014, 4:16 PM
epriestley updated this revision to Diff 20496.

Closed by commit rPc7bcecb9b0e9 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
6 lines
applications/
releeph/
application/
2 lines
controller/
project/
19 lines
ReleephProductHistoryController.php
ReleephProjectHistoryController.php
5 lines
editor/
53 lines
storage/
94 lines
15 lines

Diff 20496

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/releeph/application/PhabricatorApplicationReleeph.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductActionController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProductHistoryController.php

Loading...
View Options

src/applications/releeph/controller/project/ReleephProjectHistoryController.php

Loading...
View Options

src/applications/releeph/editor/ReleephProductEditor.php

Loading...
View Options

src/applications/releeph/storage/ReleephProductTransaction.php

Loading...
View Options

src/applications/releeph/storage/ReleephProject.php

Loading...
Phabricator · Built by Phacility