Support HTTP basic auth in HTTPFuture
ClosedPublic
Actions

Authored by epriestley on Mar 26 2014, 10:48 PM.

Tags

None

Referenced Files

	F13187005: D8621.diff
	Sat, May 11, 4:16 AM

	F13185888: D8621.diff
	Sat, May 11, 3:17 AM

	Unknown Object (File)
	Tue, May 7, 5:29 AM

	Unknown Object (File)
	Fri, May 3, 3:21 AM

	Unknown Object (File)
	Mon, Apr 29, 2:39 PM

	Unknown Object (File)
	Sat, Apr 27, 11:39 PM

	Unknown Object (File)
	Wed, Apr 24, 10:11 PM

	Unknown Object (File)
	Sun, Apr 14, 9:40 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan

Maniphest Tasks

T4590: Unable to pass in HTTP auth in the Build Plans->Make HTTP Request section

Commits

rPHU7a4f46251c21: Support HTTP basic auth in HTTPFuture

Summary

Ref T4590. We already sort of support this for Conduit, push the support a little bit deeper.

Test Plan

Added basic auth across my entire nginx. Requests with no auth or with the wrong auth failed; requests with the right auth worked.

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20455.Mar 26 2014, 10:48 PM

epriestley retitled this revision from to Support HTTP basic auth in HTTPFuture.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4590: Unable to pass in HTTP auth in the Build Plans->Make HTTP Request section.

Herald added a subscriber: epriestley.Mar 26 2014, 10:48 PM

btrahan accepted this revision.Mar 26 2014, 10:53 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 26 2014, 10:53 PM

Closed by commit rPHU7a4f46251c21 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

conduit/

ConduitClient.php

15 lines

future/

http/

BaseHTTPFuture.php

19 lines

Diff 20464

View Options

src/conduit/ConduitClient.php