Page MenuHomePhabricator

Downgrade accepts on "request changes", and make sticky accepts optional
ClosedPublic

Authored by epriestley on Mar 25 2014, 10:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 1, 6:47 PM
Unknown Object (File)
Sun, Aug 25, 7:09 AM
Unknown Object (File)
Sat, Aug 17, 3:40 AM
Unknown Object (File)
Fri, Aug 16, 9:37 PM
Unknown Object (File)
Aug 7 2024, 3:43 PM
Unknown Object (File)
Aug 6 2024, 1:46 AM
Unknown Object (File)
Jul 28 2024, 9:29 PM
Unknown Object (File)
Jul 28 2024, 3:15 AM
Subscribers

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPed2e12047af4: Downgrade accepts on "request changes", and make sticky accepts optional
Summary

Fixes T3202. This fixes a couple of workflow issues:

  • Accepted Revision -> Request Review. Currently this stays "accepted" due to sticky rules being too aggressive, but should transition to "needs review".
  • Accepted Revision -> Plan Changes -> Request Review. Currently this stays "accepted". I think this behavior is correct, and have retained it. (In this case, you don't update the revision, you just "undo" your plan changes.) You can "Request Review" again to get back to "Needs Review".

Then implements a "sticky accept" switch:

  • When off, updates downgrade accepts.
  • When off, "request review" always downgrades accepts.
Test Plan
  • Went through all (I think?) of the plan changes / request review / accept / update workflows, with sticky accept on and off.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Downgrade accepts on "request changes", and make sticky accepts optional.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 25 2014, 10:35 PM
epriestley updated this revision to Diff 20427.

Closed by commit rPed2e12047af4 (authored by @epriestley).