Page MenuHomePhabricator

Prevent buildable list in Harbormaster from breaking when container or buildables are missing
ClosedPublic

Authored by hach-que on Mar 24 2014, 3:30 AM.
Tags
None
Referenced Files
F15446826: D8608.id20398.diff
Thu, Mar 27, 8:26 PM
F15444135: D8608.id20398.diff
Thu, Mar 27, 8:01 AM
F15443715: D8608.id.diff
Thu, Mar 27, 5:49 AM
F15440953: D8608.id20439.diff
Wed, Mar 26, 3:40 PM
F15438853: D8608.diff
Wed, Mar 26, 4:07 AM
F15422859: D8608.id20398.diff
Sat, Mar 22, 11:05 AM
F15389743: D8608.id20439.diff
Sat, Mar 15, 5:36 AM
F15384888: D8608.diff
Fri, Mar 14, 9:05 PM

Details

Summary

Ref T1049. I'm fair sure this is just a case of bad data in my local install, but we probably don't want the default page for Harbormaster to break when there's invalid / missing container or buildable handles on any of the builds.

Test Plan

Loaded the page, didn't get a crash due to null reference.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Prevent buildable list in Harbormaster from breaking when container or buildables are missing.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

In theory, handles should always load something, but this case is a little weird and we don't have a convenient way to get/attach a totally empty handle. This seems reasonable until we have some justification for doing that.

This revision is now accepted and ready to land.Mar 26 2014, 12:35 AM
epriestley updated this revision to Diff 20439.

Closed by commit rPfc3b5ddce6a5 (authored by @hach-que, committed by @epriestley).