Paths

Table of Contentst

Issue a proper 404 when trying to edit nonexistent events
ClosedPublic
Actions

Authored by epriestley on Mar 22 2014, 12:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 18, 2:53 AM

	Unknown Object (File)
	Tue, Feb 11, 5:36 PM

	Unknown Object (File)
	Sun, Feb 9, 12:00 PM

	Unknown Object (File)
	Sun, Feb 9, 12:00 PM

	Unknown Object (File)
	Sun, Feb 9, 12:00 PM

	Unknown Object (File)
	Sun, Feb 2, 4:03 PM

	Unknown Object (File)
	Thu, Jan 23, 11:48 PM

	Unknown Object (File)
	Thu, Jan 23, 12:47 PM

View All Files

Subscribers

epriestley

Tokens

"Like" token, awarded by michiel3.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPae03cb7fff69: Issue a proper 404 when trying to edit nonexistent events

Summary

We'll fatal a little later here when trying to call methods. 404 instead.

Test Plan

Visited /calendar/event/edit/9999999/ or similar.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 20373.Mar 22 2014, 12:17 AM

epriestley retitled this revision from to Issue a proper 404 when trying to edit nonexistent events.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

Herald added a subscriber: epriestley.Mar 22 2014, 12:17 AM

chad accepted this revision.Mar 22 2014, 12:23 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 22 2014, 12:23 AM

Closed by commit rPae03cb7fff69 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventEditController.php

3 lines

Diff 20374

View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Issue a proper 404 when trying to edit nonexistent eventsClosedPublicActions