Page MenuHomePhabricator

Make dialogs a little easier to use
ClosedPublic

Authored by epriestley on Mar 20 2014, 1:04 PM.
Tags
None
Referenced Files
F15435841: D8577.id20371.diff
Tue, Mar 25, 10:31 AM
F15435840: D8577.id20353.diff
Tue, Mar 25, 10:31 AM
F15421728: D8577.id20353.diff
Sat, Mar 22, 1:55 AM
F15382428: D8577.diff
Fri, Mar 14, 12:20 PM
F15380451: D8577.id20353.diff
Fri, Mar 14, 3:08 AM
F15374476: D8577.id20371.diff
Wed, Mar 12, 7:07 PM
Unknown Object (File)
Feb 24 2025, 11:36 AM
Unknown Object (File)
Feb 22 2025, 11:53 PM
Subscribers

Details

Reviewers
btrahan
chad
Commits
Restricted Diffusion Commit
rPd8713f6f0b8c: Make dialogs a little easier to use
Summary
  • Dialog pages currently have no titles or crumbs, and look shoddy. Add titles and crumbs.
  • Dialog titles aren't always great for crumbs, add an optional "short title" for crumbs.
  • AphrontDialogResponse is pure boilerplate. Allow controllers to just return a DialogView instead and get the same effect.
  • Building dialogs requires a bit of boilerplate, and we generally construct them with no explicit "action", which has some issues with T4593. Provide a convenience method to set the viewer and get a reasonable, explict submit URI.
Test Plan
  • Viewed dialog on its own.
  • Viewed dialog as a dialog.

Screen_Shot_2014-03-20_at_6.00.44_AM.png (993×1 px, 103 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Make dialogs a little easier to use.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 20 2014, 3:37 PM
epriestley updated this revision to Diff 20371.

Closed by commit rPd8713f6f0b8c (authored by @epriestley).