Page MenuHomePhabricator

Use modern UI and policies in OAuth client editing
ClosedPublic

Authored by epriestley on Mar 18 2014, 1:54 PM.
Tags
None
Referenced Files
F14050418: D8562.diff
Thu, Nov 14, 6:39 PM
F14036162: D8562.diff
Sun, Nov 10, 8:44 AM
F14013237: D8562.diff
Sat, Nov 2, 2:34 AM
F14006229: D8562.diff
Mon, Oct 28, 3:47 AM
F13960181: D8562.id.diff
Oct 14 2024, 10:19 PM
Unknown Object (File)
Oct 5 2024, 12:09 AM
Unknown Object (File)
Oct 2 2024, 2:03 AM
Unknown Object (File)
Sep 30 2024, 6:59 PM
Subscribers

Details

Summary

Updates this stuff a bit:

  • Add a global create permission for OAuth applications. The primary goal is to reduce attack surface area by making it more difficult for an adversary to do anything which requires that they create and configure an OAuth application/client. Normal users shouldn't generally need to create applications, OAuth is complex, and doing things with user accounts is inherently somewhat administrative.
  • Use normal policies to check create and edit permissions, now that we have infrastructure for it.
  • Use modern UI kit.
Test Plan
  • Created a client.
  • Edited a client.
  • Tried to create a client as a non-admin.
  • Tried to edit a client I don't own.

Screen_Shot_2014-03-18_at_6.49.47_AM.png (867×1 px, 113 KB)

Screen_Shot_2014-03-18_at_6.49.40_AM.png (953×1 px, 110 KB)

Screen_Shot_2014-03-18_at_6.49.50_AM.png (867×1 px, 109 KB)

Screen_Shot_2014-03-18_at_6.49.55_AM.png (953×1 px, 96 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use modern UI and policies in OAuth client editing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2014, 4:53 PM
epriestley updated this revision to Diff 20327.

Closed by commit rP34c890b7e1a8 (authored by @epriestley).