Page MenuHomePhabricator

Use modern UI and policies in OAuth client editing
ClosedPublic

Authored by epriestley on Mar 18 2014, 1:54 PM.
Tags
None
Referenced Files
F13375574: D8562.diff
Sat, Jun 29, 1:48 AM
F13356621: D8562.diff
Mon, Jun 24, 6:48 PM
F13353743: D8562.diff
Sun, Jun 23, 11:20 PM
F13335750: D8562.diff
Wed, Jun 19, 3:15 AM
F13326062: D8562.id20327.diff
Sat, Jun 15, 2:36 AM
F13326057: D8562.id.diff
Sat, Jun 15, 2:31 AM
F13326056: D8562.id20315.diff
Sat, Jun 15, 2:31 AM
F13325213: D8562.diff
Sat, Jun 15, 1:31 AM
Subscribers

Details

Summary

Updates this stuff a bit:

  • Add a global create permission for OAuth applications. The primary goal is to reduce attack surface area by making it more difficult for an adversary to do anything which requires that they create and configure an OAuth application/client. Normal users shouldn't generally need to create applications, OAuth is complex, and doing things with user accounts is inherently somewhat administrative.
  • Use normal policies to check create and edit permissions, now that we have infrastructure for it.
  • Use modern UI kit.
Test Plan
  • Created a client.
  • Edited a client.
  • Tried to create a client as a non-admin.
  • Tried to edit a client I don't own.

Screen_Shot_2014-03-18_at_6.49.47_AM.png (867×1 px, 113 KB)

Screen_Shot_2014-03-18_at_6.49.40_AM.png (953×1 px, 110 KB)

Screen_Shot_2014-03-18_at_6.49.50_AM.png (867×1 px, 109 KB)

Screen_Shot_2014-03-18_at_6.49.55_AM.png (953×1 px, 96 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use modern UI and policies in OAuth client editing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 18 2014, 4:53 PM
epriestley updated this revision to Diff 20327.

Closed by commit rP34c890b7e1a8 (authored by @epriestley).